Skip to content

[PHP 8.3] test: update expectation for highlight code - #7912

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:test-highlight-code
Sep 8, 2023
Merged

[PHP 8.3] test: update expectation for highlight code#7912
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:test-highlight-code

Conversation

@kenjis

@kenjiskenjis commented Sep 8, 2023

Copy link
Copy Markdown
Member

Description
See #7850

E.g.,

1) CodeIgniter\Helpers\TextHelperTest::testHighlightCode
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<code><span style="color: #000000">
-<span style="color: #0000BB">&lt;?php&nbsp;var_dump</span><span style="color: #007700">(</span><span style="color: #0000BB">$this</span><span style="color: #007700">);&nbsp;</span><span style="color: #0000BB">?&gt;&nbsp;</span>
-</span>
-</code>'
+'<pre><code style="color: #000000"><span style="color: #0000BB">&lt;?php var_dump</span><span style="color: #007700">(</span><span style="color: #0000BB">$this</span><span style="color: #007700">); </span><span style="color: #0000BB">?&gt; ?&gt;</span></code></pre>'
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Helpers/TextHelperTest.php:267

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6035726283/job/16376653028?pr=7886

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjiskenjis added the testing Pull requests that changes tests only label Sep 8, 2023
@kenjiskenjis mentioned this pull request Sep 8, 2023
6 tasks
Comment threadtests/system/Helpers/TextHelperTest.php Outdated
@kenjis
kenjis merged commit 1891963 into codeigniter4:developSep 8, 2023
@kenjis
kenjis deleted the test-highlight-code branch September 8, 2023 03:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testingPull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis@paulbalandan