Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -2056,26 +2056,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Encryption/Handlers/SodiumHandler.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(bool\\|int\\|string\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:set\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:set\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\BaseCast\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Parameter \\#1 \\$value \\(int\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\IntBoolCast\\:\\:get\\(\\) should be contravariant with parameter \\$value \\(array\\|bool\\|float\\|int\\|object\\|string\\|null\\) of method CodeIgniter\\\\Entity\\\\Cast\\\\CastInterface\\:\\:get\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Entity/Cast/IntBoolCast.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 4,
Expand Down
6 changes: 6 additions & 0 deletions rector.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,12 @@
__DIR__ . '/tests/system/Config/fixtures',
__DIR__ . '/tests/system/Filters/fixtures',
__DIR__ . '/tests/_support',

// Error: ] Could not process "tests/system/Entity/EntityLiveTest.php" file, due
// to:
// "Call to a member function getValue() on bool". On line: 172
__DIR__ . '/tests/system/Entity/EntityLiveTest.php',

JsonThrowOnErrorRector::class,
YieldDataProviderRector::class,

Expand Down
8 changes: 6 additions & 2 deletions system/BaseModel.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@
use CodeIgniter\Database\Exceptions\DatabaseException;
use CodeIgniter\Database\Exceptions\DataException;
use CodeIgniter\Database\Query;
use CodeIgniter\Entity\Entity;
use CodeIgniter\Exceptions\ModelException;
use CodeIgniter\I18n\Time;
use CodeIgniter\Pager\Pager;
Expand DownExpand Up@@ -1684,8 +1685,11 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
*/
protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): array
{
if ($data instanceof Entity) {
$properties = $data->toDatabase($onlyChanged, $recursive);
}
// @TODO Should define Interface or Class. Entity has toRawArray() now.
if (method_exists($data, 'toRawArray')) {
elseif (method_exists($data, 'toRawArray')) {
$properties = $data->toRawArray($onlyChanged, $recursive);
} else {
$mirror = new ReflectionClass($data);
Expand All@@ -1706,7 +1710,7 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
}

/**
* Transform data to array.
* Transform data to array that can be save to database.
*
* @param array|object|null $data Data
* @param string $type Type of data (insert|update)
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return $this->resultID->fetch_object($className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ protected function fetchObject(string $className = 'stdClass')
return $row;
}
if (is_subclass_of($className, Entity::class)) {
return (new $className())->injectRawData((array) $row);
return (new $className())->fromDatabase((array) $row);
}

$instance = new $className();
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return pg_fetch_object($this->resultID, null, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,7 +154,7 @@ protected function fetchAssoc()
protected function fetchObject(string $className = 'stdClass')
{
if (is_subclass_of($className, Entity::class)) {
return empty($data = $this->fetchAssoc()) ? false : (new $className())->injectRawData($data);
return empty($data = $this->fetchAssoc()) ? false : (new $className())->fromDatabase($data);
}

return sqlsrv_fetch_object($this->resultID, $className);
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Result.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ protected function fetchObject(string $className = 'stdClass')
$classObj = new $className();

if (is_subclass_of($className, Entity::class)) {
return $classObj->injectRawData($row);
return $classObj->fromDatabase($row);
}

$classSet = Closure::bind(function ($key, $value) {
Expand Down
16 changes: 12 additions & 4 deletions system/Entity/Cast/ArrayCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,10 +19,14 @@ class ArrayCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value);
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

if ((strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
$value = unserialize($value, ['allowed_classes' => false]);
}

return (array) $value;
Expand All@@ -31,8 +35,12 @@ public static function get($value, array $params = []): array
/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value) && ! is_string($value)) {
self::invalidTypeValueError($value);
}

return serialize($value);
}
}
45 changes: 43 additions & 2 deletions system/Entity/Cast/BaseCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,13 +11,16 @@

namespace CodeIgniter\Entity\Cast;

use TypeError;

/**
* Class BaseCast
*/
abstract class BaseCast implements CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -30,7 +33,7 @@ public static function get($value, array $params = [])
}

/**
* Set
* Returns value for Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -41,4 +44,42 @@ public static function set($value, array $params = [])
{
return $value;
}

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = [])
{
return $value;
}

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = [])
{
return $value;
}

/**
* Throws TypeError
*
* @param mixed $value
*
* @return never
*/
protected static function invalidTypeValueError($value)
{
throw new TypeError('Invalid type value: ' . var_export($value, true));
}
}
14 changes: 13 additions & 1 deletion system/Entity/Cast/BooleanCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,8 +19,20 @@ class BooleanCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): bool
public static function set($value, array $params = []): bool
{
return (bool) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): bool
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return (bool) $value;
}
}
12 changes: 10 additions & 2 deletions system/Entity/Cast/CSVCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,24 @@ class CSVCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): array
public static function fromDatabase($value, array $params = []): array
{
if (! is_string($value)) {
self::invalidTypeValueError($value);
}

return explode(',', $value);
}

/**
* {@inheritDoc}
*/
public static function set($value, array $params = []): string
public static function toDatabase($value, array $params = []): string
{
if (! is_array($value)) {
self::invalidTypeValueError($value);
}

return implode(',', $value);
}
}
28 changes: 26 additions & 2 deletions system/Entity/Cast/CastInterface.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,15 @@

/**
* Interface CastInterface
*
* [App Code] --- set() --> [Entity] --- toDatabase() ---> [Database]
* [App Code] <-- get() --- [Entity] <-- fromDatabase() -- [Database]
*/
interface CastInterface
{
/**
* Get
* Returns value when getting the Entity property.
* This method is normally returns the value as it is.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
Expand All@@ -27,12 +31,32 @@ interface CastInterface
public static function get($value, array $params = []);

/**
* Set
* Returns value for the Entity property when setting the Entity property.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function set($value, array $params = []);

/**
* Takes the Entity property value, returns its value for database.
*
* @param array|bool|float|int|object|string|null $value Data
* @param array $params Additional param
*
* @return bool|float|int|string|null
*/
public static function toDatabase($value, array $params = []);

/**
* Takes value from database, returns its value for the Entity property.
*
* @param bool|float|int|string|null $value Data
* @param array $params Additional param
*
* @return array|bool|float|int|object|string|null
*/
public static function fromDatabase($value, array $params = []);
}
32 changes: 30 additions & 2 deletions system/Entity/Cast/DatetimeCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ class DatetimeCast extends BaseCast
*
* @throws Exception
*/
public static function get($value, array $params = [])
public static function set($value, array $params = [])
{
if ($value instanceof Time) {
return $value;
Expand All@@ -45,6 +45,34 @@ public static function get($value, array $params = [])
return Time::parse($value);
}

return $value;
self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*
* @return Time
*
* @throws Exception
*/
public static function fromDatabase($value, array $params = [])
{
if (is_string($value)) {
return Time::parse($value);
}

self::invalidTypeValueError($value);
}

/**
* {@inheritDoc}
*/
public static function toDatabase($value, array $params = []): string
{
if (! $value instanceof Time) {
self::invalidTypeValueError($value);
}

return (string) $value;
}
}
10 changes: 9 additions & 1 deletion system/Entity/Cast/FloatCast.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,15 @@ class FloatCast extends BaseCast
/**
* {@inheritDoc}
*/
public static function get($value, array $params = []): float
public static function set($value, array $params = []): float
{
return (float) $value;
}

/**
* {@inheritDoc}
*/
public static function fromDatabase($value, array $params = []): float
{
return (float) $value;
}
Expand Down
Loading