refactor: add declare(strict_types=1)

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉

[kenjis]

Needs #8078, #8080, #8090, #8091, #8124, #8138, #8175, #8242, #8270

Description

• add declare(strict_types=1)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@samsonasik
The following config does not work.
DeclareStrictTypesRector does not skip files in app/ or other folders.
Is there something wrong?

--- a/rector.php+++ b/rector.php@@ -44,6 +44,7 @@ use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Utils\Rector\PassStrictParameterToFunctionParameterRector;
use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector;
use Utils\Rector\RemoveVarTagFromClassConstantRector;
@@ -107,6 +108,15 @@ return static function (RectorConfig $rectorConfig): void {
__DIR__ . '/system/Session/Handlers',
],
+ DeclareStrictTypesRector::class => [+ __DIR__ . '/app',+ __DIR__ . '/system/Commands/Generators/Views',+ __DIR__ . '/system/Pager/Views',+ __DIR__ . '/system/Validation/Views',+ __DIR__ . '/system/View/Parser.php',+ __DIR__ . '/tests/system/View/Views',+ ],+
// use mt_rand instead of random_int on purpose on non-cryptographically random
RandomFunctionRector::class,
@@ -117,6 +127,7 @@ return static function (RectorConfig $rectorConfig): void {
$rectorConfig->importNames();
$rectorConfig->removeUnusedImports();
+ $rectorConfig->rule(DeclareStrictTypesRector::class);
$rectorConfig->rule(UnderscoreToCamelCaseVariableNameRector::class);
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);

[samsonasik]

I am on mobile, but that seems a bug due to DeclareStrictTypesRector run on beforeTraverse() while skipping check happen on enterNode() so that overlapped.

[samsonasik]

Reproduced at Rector side:

• [TypeDeclaration] Handle skipped by file path on DeclareStrictTypesRector due to use beforeTraverse() rectorphp/rector-src#5191

[MGatner]

What a long-standing conversation! I think this is the right time to do this. @lonnieezell What was our strict_types friend? John something... Should mention him here.

[MGatner]

@John-Betong

[neznaika0]

I like type control.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

All checks have passed! 🎉

[kenjis]

Now in 4.5 branch, most files have declare(strict_types=1)! 🎉