fix: validation rule `matches` and `differs` by kenjis · Pull Request #8122 · codeigniter4/CodeIgniter4

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis · 2023-10-29T21:07:57Z

Description

fix TypeError in Strict Rules
fix behaviors
- Strict Rules: e89fbd8#diff-7418849ccba3c428c9c850f68e98a540d116ead6b80e37e0963290bc861207fe
- Traditional Rules are changed to the same as CI3 behavior: 36c0de9#diff-cf7521c5d54b849f1a6fab1604700fdb41c3319230f71eab68e5922c099531f9

Note: Adding ?string in CI4 makes the behavior different from that of CI3. There may be similar bugs in other Traditional Rules.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-29T21:42:23Z

CI3's behaviors:

publicfunctiontest_rule_matches()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'matches[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ''))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertTrue($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}
publicfunctiontest_rule_differs()
{
$rules = array(
array('field' => 'foo', 'label' => 'label', 'rules' => 'required'),
array('field' => 'bar', 'label' => 'label2', 'rules' => 'differs[foo]')
);
$values_base = array('foo' => 'sample');
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'does_not_match'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => 'Sample'))));
$this->assertTrue($this->run_rules($rules, array_merge($values_base, array('bar' => ' sample'))));
$this->assertFalse($this->run_rules($rules, array_merge($values_base, array('bar' => 'sample'))));
$this->assertFalse($this->run_rules($rules, []));
$this->assertFalse($this->run_rules($rules, ['foo' => null]));
$this->assertFalse($this->run_rules($rules, ['bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => null, 'bar' => null]));
$this->assertFalse($this->run_rules($rules, ['foo' => 1.2, 'bar' => 1.2]));
$this->assertTrue($this->run_rules($rules, ['foo' => 1.2, 'bar' => 2.3]));
$this->assertFalse($this->run_rules($rules, ['foo' => true, 'bar' => true]));
}

kenjis · 2023-11-02T07:59:03Z

add docs.

github-actions · 2023-11-03T00:36:27Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Match CI3 behaviros.

kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Oct 29, 2023

kenjis marked this pull request as draft October 29, 2023 21:15

kenjis changed the title ~~fix: validation strict rule matches and differs~~fix: validation rule matches and differsOct 29, 2023

kenjis force-pushed the fix-validation-matches-and-differs branch from 0200da4 to 36c0de9Compare October 29, 2023 21:44

kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Oct 30, 2023

kenjis mentioned this pull request Oct 30, 2023
fix: remove traditional validation rule param types (2/2) #8124
Merged
5 tasks

kenjis force-pushed the fix-validation-matches-and-differs branch from d90fc02 to b156c13Compare November 2, 2023 07:57

kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Nov 2, 2023

kenjis marked this pull request as ready for review November 2, 2023 07:57

kenjis force-pushed the fix-validation-matches-and-differs branch from b156c13 to b154caeCompare November 2, 2023 08:02

github-actionsBot added the stale Pull requests with conflicts label Nov 3, 2023

kenjis added 5 commits November 3, 2023 09:41

test: add tests for current behavior to matches and differs
45e2027

fix: strict validation rule matches and differs
c06e0b3

fix: traditional validation rule matches and differs
c83e2ea
Match CI3 behaviros.

refactor: by rector
fdd9ec8

docs: add changelog and upgrade
db0ad7e

kenjis force-pushed the fix-validation-matches-and-differs branch from b154cae to db0ad7eCompare November 3, 2023 00:43

kenjis removed the stale Pull requests with conflicts label Nov 3, 2023

MGatner reviewed Nov 5, 2023
View reviewed changes

Comment threadsystem/Validation/Rules.php

MGatner approved these changes Nov 7, 2023
View reviewed changes

kenjis merged commit eebec16 into codeigniter4:developNov 7, 2023

kenjis deleted the fix-validation-matches-and-differs branch November 7, 2023 21:47