style: update coding style by php-cs-fixer v3.42.0 by kenjis · Pull Request #8367 · codeigniter4/CodeIgniter4

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

kenjis · 2023-12-25T08:10:40Z

Description
Update by php-cs-fixer v3.42.0

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide

Update by php-cs-fixer v3.42.0

kenjis · 2023-12-25T08:30:19Z

Rector adds unneeded @see tags, but it seems to be intentional.

Add @see annotation test of the class for faster jump to test. Make it FQN, so it stays in the annotation, not in the PHP source code.
https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addseetestannotationrector

1) system/Commands/Database/MigrateStatus.php:18
---------- begin diff ----------
@@ @@
* Displays a list of all migrations and whether they've been run or not.
*
* @see MigrateStatusTest
+ * @see \CodeIgniter\Commands\Database\MigrateStatusTest
*/
class MigrateStatus extends BaseCommand
{
----------- end diff -----------
Applied rules:
* AddSeeTestAnnotationRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7320300308/job/19939228674?pr=8367

See codeigniter4#8367 (comment)

kenjis · 2023-12-25T08:59:33Z

@sammyskills Do you think #8367 (comment) is a bug in AddSeeTestAnnotationRector?

See codeigniter4#8367 (comment)

sammyskills · 2023-12-25T09:09:59Z

No, I don't think so.

From the docs:

Make it FQN, so it stays in the annotation, not in the PHP source code.

So, the FQN annotation should be used instead.

kenjis · 2023-12-25T10:04:54Z

@sammyskills Sorry, I was confused. But thank you for your comment.

I mean @samsonasik See #8367 (comment)

samsonasik · 2023-12-25T10:12:51Z

i am on mobile, iirc, @see is generic tag iirc, so that value is detected as text so that expected, i think fqcn should be used.

kenjis · 2023-12-25T11:12:05Z

@sammyskills @samsonasik Thank you.
I sent a bug report PHP-CS-Fixer/PHP-CS-Fixer#7620

kenjis · 2023-12-25T11:35:08Z

+ /** @param array<array-key, string> $matches */
+ function (array $matches): string {
+ return $this->cssMatcher($matches);
+ };


Oh, I accidentally added these changes...

style: composer cs-fix
6bf410c
Update by php-cs-fixer v3.42.0

kenjis changed the title ~~style: composer cs-fix~~style: update coding style by php-cs-fixer v3.42.0Dec 25, 2023

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Dec 25, 2023
chore: fix php-cs-fixer version to 3.41.*
a4cb43e
See codeigniter4#8367 (comment)

kenjis mentioned this pull request Dec 25, 2023
chore: fix php-cs-fixer version to 3.41.* #8368
Merged
1 task

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Dec 25, 2023
chore: fix php-cs-fixer version to 3.41.*
0ff55ad
See codeigniter4#8367 (comment)

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Dec 25, 2023
chore: fix php-cs-fixer version to 3.41.*
1354ae7
See codeigniter4#8367 (comment)

kenjis marked this pull request as draft December 25, 2023 11:32

kenjis commented Dec 25, 2023
View reviewed changes

kenjis closed this Dec 25, 2023

kenjis deleted the update-cs-by-v3.42.0 branch December 29, 2023 00:56