perf: add Services::get() by kenjis · Pull Request #8607 · codeigniter4/CodeIgniter4

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis · 2024-03-04T08:39:26Z

Description

add Services::get() method to get the shared instance fast.
service() uses Services::get()

 Test Time Memory
services::timer() 0.1337 0 Bytes
services::get('timer') 0.0406 0 Bytes
service('timer') 0.0528 0 Bytes

<?phpnamespaceApp\Controllers;
useCodeIgniter\Debug\Iterator;
useConfig\Services;
class Home extends BaseController
{
publicfunctionindex(): string
{
$iterator = newIterator();
Services::timer();
$iterator->add('Services::timer()', staticfunction () {
$timer = Services::timer();
});
$iterator->add("Services::get('timer')", staticfunction () {
$timer = Services::get('timer');
});
$iterator->add("service('timer')", staticfunction () {
$timer = service('timer');
});
return$iterator->run(300000);
}
}

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

paulbalandan · 2024-03-05T04:41:05Z

+ *
+ * @return mixed Entry.
+ */
+ public static function get(string $key): mixed


Applicable review until override().
mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

Changed to ?object.

paulbalandan · 2024-03-05T04:41:44Z

+ * Sets an entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment before.

paulbalandan · 2024-03-05T04:42:27Z

+ public static function set(string $key, mixed $value): void
+ {
+ if (isset(static::$instances[$key])) {
+ throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');


Suggested change
thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

paulbalandan · 2024-03-05T04:42:43Z

+ * Overrides an existing entry.
+ *
+ * @param string $key Identifier of the entry.
+ * @param mixed $value Normally an object.


See comment above

lonnieezell · 2024-03-08T14:58:14Z

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

kenjis · 2024-03-08T23:41:16Z

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep functionsystem/Config/BaseService.php public static function get(string $key): ?object public static function set(string $key, object $value): void public static function override(string $key, object $value): void protected static function getSharedInstance(string $key, ...$params) public static function autoloader(bool $getShared = true) public static function locator(bool $getShared = true) public static function __callStatic(string $name, array $arguments) public static function serviceExists(string $name): ?string public static function reset(bool $initAutoloader = true) public static function resetSingle(string $name) public static function injectMock(string $name, $mock) protected static function buildServicesCache(): void

lonnieezell · 2024-03-09T05:18:54Z

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

neznaika0 · 2024-11-01T16:24:45Z

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37
---------- begin diff ----------
@@ @@
/**
* @var CLIRequest|IncomingRequest
*/
- private $request;+ private ?object $request = null;
private Response $response;
----------- end diff -----------
Applied rules:
* TypedPropertyFromAssignsRector

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

kenjis added refactor Pull requests that refactor code 4.5 labels Mar 4, 2024

kenjis added 6 commits March 4, 2024 17:45

docs: make@varmore detailed
b6556f7

feat: add Services::get(),set(),override()
39bed21

refactor: use service() in framework code
3880337

refactor: use Services::get() in service()
8084f1e

refactor: use Services::get() in Config\Services
d23acf0

feat: add $factories to save factory methods
9ac1dda

kenjis force-pushed the feat-Services-get branch from 4f185b0 to 9ac1ddaCompare March 4, 2024 08:46

refactor: by rector
c9a4bb8

lonnieezell approved these changes Mar 4, 2024
View reviewed changes

ddevsr approved these changes Mar 4, 2024
View reviewed changes

paulbalandan reviewed Mar 5, 2024
View reviewed changes

kenjis added 2 commits March 5, 2024 14:09

fix: exception message
c821b69

fix: paramete/return types
1db8db6

paulbalandan approved these changes Mar 5, 2024
View reviewed changes

kenjis merged commit 452543e into codeigniter4:4.5Mar 7, 2024

kenjis deleted the feat-Services-get branch March 7, 2024 07:35

ddevsr mentioned this pull request Mar 14, 2024
refactor: followup performance service()#8623
Merged
5 tasks

kenjis mentioned this pull request Aug 18, 2024
docs: replace Services class to service()#8928
Merged
5 tasks

neznaika0 mentioned this pull request Nov 2, 2024
perf: Improve call as service()#9248
Merged
5 tasks

	thrownewInvalidArgumentException('The Entry for "' . $key . '" is already set.');
	thrownewInvalidArgumentException('The entry for "' . $key . '" is already set.');

Uh oh!

Conversation

kenjis commented Mar 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lonnieezell commented Mar 8, 2024

Uh oh!

kenjis commented Mar 8, 2024

Uh oh!

lonnieezell commented Mar 9, 2024

Uh oh!

neznaika0 commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

kenjis commented Mar 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lonnieezell commented Mar 8, 2024

Uh oh!

kenjis commented Mar 8, 2024

Uh oh!

lonnieezell commented Mar 9, 2024

Uh oh!

neznaika0 commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

kenjis commented Mar 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

kenjis commented Mar 4, 2024•
edited
Loading

kenjis commented Mar 4, 2024•
edited
Loading

kenjis commented Mar 4, 2024•
edited
Loading

kenjis commented Mar 4, 2024•
edited
Loading