Skip to content

refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 2 commits into from
Apr 11, 2024
Merged

refactor: system/CLI/BaseCommand.php #8741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5213fe
test: refactor system/CLI/BaseCommand.php
mcsaygili Apr 9, 2024
2a6591a
Fix doc type ordering in BaseCommand.php following PHPStan guidelines…
mcsaygili Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
'count' => 1,
'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 2,
'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
'count' => 1,
Expand Down
10 changes: 7 additions & 3 deletions system/CLI/BaseCommand.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
/**
* Can be used by a command to run other commands.
*
* @param array<int|string, string|null> $params
*
* @return int|void
*
* @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
{
CLI::write(lang('CLI.helpUsage'), 'yellow');

if (! empty($this->usage)) {
if (isset($this->usage)) {
$usage = $this->usage;
} else {
$usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

CLI::write($this->setPad($usage, 0, 0, 2));

if (! empty($this->description)) {
if (isset($this->description)) {
CLI::newLine();
CLI::write(lang('CLI.helpDescription'), 'yellow');
CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
/**
* Get pad for $key => $value array output
*
* @param array<string, string> $array
*
* @deprecated Use setPad() instead.
*
* @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
/**
* Makes it simple to access our protected properties.
*
* @return array|Commands|LoggerInterface|string|null
* @return array<string, string>|Commands|LoggerInterface|string|null
*/
public function __get(string $key)
{
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
refactor: system/CLI/BaseCommand.php by mcsaygili · Pull Request #8741 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/CLI/BaseCommand.php#8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 2 commits into

from

Apr 11, 2024
 Merged


refactor: system/CLI/BaseCommand.php
#8741
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
a5213fe

test: refactor system/CLI/BaseCommand.php


mcsaygili Apr 9, 2024
2a6591a

Fix doc type ordering in BaseCommand.php following PHPStan guidelines…


mcsaygili Apr 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 0 additions & 20 deletions
phpstan-baseline.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -261,26 +261,6 @@
	'count' => 1,
	'path' => __DIR__ . '/system/BaseModel.php',
];
$ignoreErrors[] = [
	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
	'count' => 2,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:__get\\(\\) return type has no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:call\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Method CodeIgniter\\\\CLI\\\\BaseCommand\\:\\:getPad\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/system/CLI/BaseCommand.php',
];
$ignoreErrors[] = [
	'message' => '#^Accessing offset \'ANSICON\' directly on \\$_SERVER is discouraged\\.$#',
	'count' => 1,
Expand Down

10 changes: 7 additions & 3 deletions
system/CLI/BaseCommand.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,6 +108,8 @@ abstract public function run(array $params);
 /**
 * Can be used by a command to run other commands.
 *
 * @param array<int|string, string|null> $params
 *
 * @return int|void
 *
 * @throws ReflectionException
Expand DownExpand Up@@ -140,7 +142,7 @@ public function showHelp()
 {
 CLI::write(lang('CLI.helpUsage'), 'yellow');

 if (! empty($this->usage)) {
 if (isset($this->usage)) {
 $usage = $this->usage;
 } else {
 $usage = $this->name;
Expand All@@ -152,7 +154,7 @@ public function showHelp()

 CLI::write($this->setPad($usage, 0, 0, 2));

 if (! empty($this->description)) {
 if (isset($this->description)) {
 CLI::newLine();
 CLI::write(lang('CLI.helpDescription'), 'yellow');
 CLI::write($this->setPad($this->description, 0, 0, 2));
Expand DownExpand Up@@ -194,6 +196,8 @@ public function setPad(string $item, int $max, int $extra = 2, int $indent = 0):
 /**
 * Get pad for $key => $value array output
 *
 * @param array<string, string> $array
 *
 * @deprecated Use setPad() instead.
 *
 * @codeCoverageIgnore
Expand All@@ -212,7 +216,7 @@ public function getPad(array $array, int $pad): int
 /**
 * Makes it simple to access our protected properties.
 *
 * @return array|Commands|LoggerInterface|string|null
 * @return array<string, string>|Commands|LoggerInterface|string|null
 */
 public function __get(string $key)
 {
Expand Down