fix: [QueryBuilder] TypeError in join() with BETWEEN

[kenjis]

Description
Fixes#8791

This PR makes the same behavior as v4.4.x or before.

• ad hoc fix

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Can someone review?

[michalsn]

I would rather see the use of RawSql for complicated conditions, but since the issue with BETWEEN is described as a regression, I think this is fine.

[oyama-pai]

The version has been upgraded to 4.5.2.
Query builder class "->insert()" now displays errors on my VS Code.

$model = new HogeModel();
$data = [
'hoge' => 'fuga'
];
$model->insert($data);

"Argument '1' passed to insert() is expected to be of type object|row_array|null, array given"

Please fix it.
(*ᴗˬᴗ)⁾⁾⁾

[kenjis]

Why your VS Code reads @phpstan-param instead of @param?

CodeIgniter4/system/Model.php

Lines 779 to 788 in 53bfdef

	* @param array|object|null $row
	* @phpstan-param row_array|object|null $row
	* @param bool $returnID Whether insert ID should be returned or not.
	*
	* @return bool|int|string
	* @phpstan-return ($returnID is true ? int|string|false : bool)
	*
	* @throws ReflectionException
	*/
	publicfunctioninsert($row = null, bool$returnID = true)

If it reads @phpstan-param, it should know row_array.

CodeIgniter4/system/BaseModel.php

Line 50 in 53bfdef

* @phpstan-type row_array array<int|string, float|int|null|object|string>

[oyama-pai]

Thank you.
It's seems to be due to my dev environment or VSCode settings.
but why????

Windows 11 Pro 23H2 WSL2
Ubuntu 22.04.4

It was very helpful.
Thank you.

[oyama-pai]

???
When open CodeIgniter4/system/Model.php is error disappears.
But when I close /Mdel.php file display error line.

Model.php on line 268 & BaseModel.php on line 656 is displays "undefined property" error form intelephense.

Here and now (´；д；`)

[oyama-pai]

Bad

$model = newHogeModel();
$data = [
'hoge' => 'fuga'
];
$model->insert($data);

Good

privatefunctionhoge()
{
$data = [
'hoge' => 'fuga'
];
$this->insertHoge($data);
}
privatefunctioninsertHoge($data)
{
$model = newHogeModel();
$model->insert($data);
}