fix: Forge::dropColumn() seems to always return false.

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[ping-yee]

Description
Fixes#8849
I think return sql execute result directly is a simplest way to fix this issue.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

dropColumn() may return false when $this->db->DBDebug is false.
So make this the same, please.

CodeIgniter4/system/Database/Forge.php

Lines 787 to 800 in f60d277

	publicfunctiondropColumn(string$table, $columnNames)
	{
	$sql = $this->_alterTable('DROP', $this->db->DBPrefix . $table, $columnNames);
	if ($sql === false) {
	if ($this->db->DBDebug) {
	thrownewDatabaseException('This feature is not available for the database you are using.');
	}
	returnfalse;
	}
	return$this->db->query($sql);
	}

[kenjis]

@ping-yee Can you complete this PR?
We are very close to the completion.

[ping-yee]

@kenjis Sorry for the stagnation, I haven’t had much energy to deal with things other than work a while ago.
I modify this right now.

[ping-yee]

Done.

[ping-yee]

However, the rector removed the return false line, implying that if sqlExecuteResult is false, the method would still return false.

[github-actions]

👋 Hi, @ping-yee!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch