Skip to content

config: change default config for Auto Routing Improved - #8981

Merged
kenjis merged 27 commits into
codeigniter4:4.6from
kenjis:change-auto-routing-improved-config
Jun 25, 2024
Merged

config: change default config for Auto Routing Improved#8981
kenjis merged 27 commits into
codeigniter4:4.6from
kenjis:change-auto-routing-improved-config

Conversation

@kenjis

@kenjiskenjis commented Jun 21, 2024

Copy link
Copy Markdown
Member

Needs #8980

Description

  • change the default values:
    • Feature::$autoRoutesImproved -> true
    • Routing::$translateUriToCamelCase -> true
  • add new page for "Auto Routing (Improved)" in the user guide

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added the 4.6 label Jun 21, 2024
@kenjis
kenjis marked this pull request as draft June 21, 2024 04:38
@kenjis
kenjisforce-pushed the change-auto-routing-improved-config branch 5 times, most recently from cd8bd92 to 5dd958eCompareJune 21, 2024 07:12
@kenjiskenjis added the documentation Pull requests for documentation only label Jun 21, 2024
@kenjis
kenjis marked this pull request as ready for review June 21, 2024 07:55
@kenjis
kenjis marked this pull request as draft June 21, 2024 07:58
@kenjis
kenjisforce-pushed the change-auto-routing-improved-config branch from 9c00f98 to 61ae88eCompareJune 23, 2024 13:00
@github-actionsgithub-actionsBot added the stale Pull requests with conflicts label Jun 24, 2024
@github-actions

Copy link
Copy Markdown

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis
kenjisforce-pushed the change-auto-routing-improved-config branch from 61ae88e to ecfbc2fCompareJune 24, 2024 09:35
@kenjiskenjis removed the stale Pull requests with conflicts label Jun 24, 2024
@kenjis

Copy link
Copy Markdown
MemberAuthor

Screenshot 2024-06-24 at 18-40-26 Auto Routing (Improved) — CodeIgniter 4 5 2 documentation

@kenjis
kenjis marked this pull request as ready for review June 24, 2024 09:44

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis

Copy link
Copy Markdown
MemberAuthor

I have made a few improvements.
Screenshot 2024-06-25 at 08-50-04 Auto Routing (Improved) — CodeIgniter 4 5 2 documentation

Examples of Controller Names
****************************

This is an valid controller name. Because ``App\Controllers\HelloWorld`` is CamelCase.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I didn't like using 'This is', it made the review difficult for me.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to The following is.


1. The first segment represents the controller **class** that should be invoked.
2. The second segment represents the class **method** that should be called.
3. The third, and any additional segments, represent any **parameters** that will be passed to the controller.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took from this sentence that the parameters are sent to the controller.
But the parameters are sent to the methods in the controller.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to the controller method.

@neznaika0

Copy link
Copy Markdown
Contributor

I think it's worth adding a note about Filters.
Won't they be available ONLY through URIs?

@kenjis

Copy link
Copy Markdown
MemberAuthor

@neznaika0 Added.
Screenshot 2024-06-25 14 41 59

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis
kenjis merged commit 4722157 into codeigniter4:4.6Jun 25, 2024
@kenjis
kenjis deleted the change-auto-routing-improved-config branch June 25, 2024 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationPull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@neznaika0@michalsn@datamweb