feat: full support on `PHP8.4` by ddevsr · Pull Request #9255 · codeigniter4/CodeIgniter4

ddevsr · 2024-11-05T10:01:44Z

Description
Review without ignore-platform-php, Reference to #9116 latest checklist.

fakerphp/php PHP 8.4 Support FakerPHP/Faker#904 release on v1.24
vimeo/psalm Add support for PHP 8.4 vimeo/psalm#10928
friendsofphp/php-cs-fixer PHP-CS-Fixer/PHP-CS-Fixer/milestone/173
predis/predis explicitly mark nullable parameters as nullable predis/predis#1448 release on v2.3.0
kint-php/kint chore: update Kint to v6.0 #9289 release on v6.0
mikey179/vfsstream Fix PHP 8.4 deprecate-implicitly-nullable-types bovigo/vfsStream#290 release on v1.6.12

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

neznaika0 · 2024-11-05T12:23:28Z

php-cs-fixer:

Note Each new PHP version requires a huge effort to support the new syntax. That's why the latest PHP version might not be supported yet. If you need it, please, consider supporting the project in any convenient way, for example with code contribution or reviewing existing PRs. To run PHP CS Fixer on yet unsupported versions "at your own risk" - leverage the PHP_CS_FIXER_IGNORE_ENV.

ddevsr · 2024-11-08T03:23:01Z

FakerPHP/Faker already merge, release soon on v1.24.

github-actions · 2024-11-21T03:02:37Z

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

github-actions · 2024-12-02T06:18:53Z

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

ddevsr · 2024-12-03T07:46:52Z

Last dependencies vimeo/psalm will be release v6 in this week

paulbalandan · 2024-12-03T08:19:18Z

How about for php-cs-fixer?

ddevsr · 2024-12-03T09:09:46Z

@paulbalandan Added test again with PHP_CS_FIXER_IGNORE_ENV, running smooth

paulbalandan

Please add the PHP_CS_FIXER_IGNORE_ENV flag to the CS github actions YML file instead of in composer.json. This way the flag is only added when PHP is 8.4

michalsn

Looks good, thanks for stepping in and taking care of it.

Although I don't think we'll wait for php-cs-fixer to be released - current support is sufficient.

ddevsr · 2024-12-16T10:34:08Z

@michalsn @paulbalandan Lets merge?

paulbalandan · 2024-12-16T10:37:54Z

Are there no more blocking deps?

ddevsr · 2024-12-16T10:45:17Z

Composer ignore-platform-req in utils for Psalm only. PHP-CS-Fixer just waiting full support, but in this project no issue

paulbalandan · 2024-12-16T11:42:12Z

Ok, our build seems passing so this can be merged.

michalsn · 2024-12-17T07:53:15Z

Thank you @ddevsr!

ddevsr changed the title ~~refactor: review github CI on PHP8.4~~refactor: review github CI on PHP8.4Nov 5, 2024

ddevsr force-pushed the review-php84 branch from 4ffba08 to 727cc5dCompare November 6, 2024 04:14

ddevsr added github_actions Pull requests that update Github_actions code 4.6 labels Nov 6, 2024

ddevsr force-pushed the review-php84 branch from c009ab7 to cd67f72Compare November 11, 2024 02:04

github-actionsBot added the stale Pull requests with conflicts label Nov 21, 2024

ddevsr force-pushed the review-php84 branch from 1f5cae4 to 99e50b7Compare November 21, 2024 03:23

ddevsr removed the stale Pull requests with conflicts label Nov 21, 2024

ddevsr force-pushed the review-php84 branch from 99e50b7 to d17e8c8Compare November 22, 2024 08:35

github-actionsBot added the stale Pull requests with conflicts label Dec 2, 2024

refactor: review github CI on PHP8.4
b381319

ddevsr force-pushed the review-php84 branch from d17e8c8 to d64d277Compare December 2, 2024 06:38

ddevsr removed the stale Pull requests with conflicts label Dec 2, 2024

ddevsr changed the title ~~refactor: review github CI on PHP8.4~~feat: full support on PHP8.4Dec 3, 2024

ddevsr requested review from kenjis, michalsn and paulbalandan December 3, 2024 08:10

ddevsr added 3 commits December 3, 2024 15:59

refactor: bump fakerphp/faker to v1.24 as minimum required
8e1272c

refactor: bump mikey179/vfsstream to v1.6.12 as minimum required
814c64a

refactor: bump predis/predis to v2.3 as minimum required
08d1a69

ddevsr force-pushed the review-php84 branch from d64d277 to 45421b7Compare December 3, 2024 09:01

paulbalandan reviewed Dec 3, 2024
View reviewed changes

ddevsr force-pushed the review-php84 branch from 45421b7 to f51cba5Compare December 4, 2024 04:39

paulbalandan reviewed Dec 4, 2024
View reviewed changes

Comment thread.github/workflows/test-coding-standards.yml Outdated

temporary ignore env PHP-CS-Fixer in github action
4ee32ed

ddevsr force-pushed the review-php84 branch from 0a023ff to 4ee32edCompare December 4, 2024 06:31

michalsn reviewed Dec 4, 2024
View reviewed changes

paulbalandan approved these changes Dec 4, 2024
View reviewed changes

michalsn approved these changes Dec 16, 2024
View reviewed changes

ddevsr marked this pull request as ready for review December 16, 2024 10:32

michalsn merged commit cd5dda1 into codeigniter4:4.6Dec 17, 2024

ddevsr deleted the review-php84 branch December 17, 2024 09:21

paulbalandan mentioned this pull request Dec 30, 2024
Dev: PHP 8.4 support #9116
Closed
16 tasks

paulbalandan mentioned this pull request Jan 19, 2025
4.6.0 Merge code #9417
Merged

Uh oh!

Conversation

ddevsr commented Nov 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neznaika0 commented Nov 5, 2024

Uh oh!

ddevsr commented Nov 8, 2024

Uh oh!

github-actionsBot commented Nov 21, 2024

Uh oh!

github-actionsBot commented Dec 2, 2024

Uh oh!

ddevsr commented Dec 3, 2024

Uh oh!

paulbalandan commented Dec 3, 2024

Uh oh!

ddevsr commented Dec 3, 2024

Uh oh!

paulbalandan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michalsn left a comment

Choose a reason for hiding this comment

Uh oh!

ddevsr commented Dec 16, 2024

Uh oh!

paulbalandan commented Dec 16, 2024

Uh oh!

ddevsr commented Dec 16, 2024

Uh oh!

paulbalandan commented Dec 16, 2024

Uh oh!

michalsn commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ddevsr commented Nov 5, 2024•
edited
Loading