Skip to content

fix: baseURI for curlrequest and image/jpg for jpg mime - #9280

Closed
warmbook wants to merge 1 commit into
codeigniter4:developfrom
warmbook:develop
Closed

fix: baseURI for curlrequest and image/jpg for jpg mime#9280
warmbook wants to merge 1 commit into
codeigniter4:developfrom
warmbook:develop

Conversation

@warmbook

@warmbookwarmbook commented Nov 15, 2024

Copy link
Copy Markdown

#9265
Description
Use 'baseURI' instead of 'base_uri' as the manual described.
Add 'image/jpg' mime for file extension jpg.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@warmbookwarmbook changed the title baseURI for curlrequest and image/jpg for jpg mimefix: baseURI for curlrequest and image/jpg for jpg mimeNov 15, 2024

@neznaika0neznaika0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your desire for improvement.
It is recommended to divide PR by meaning. The first change refers to CURL, the second to Config. This is for you in the future

@michalsn

Copy link
Copy Markdown
Member

One "issue" one PR, please.

@warmbook

Copy link
Copy Markdown
Author

One "issue" one PR, please.

Sorry! I forgot it.

@ddevsr

ddevsr commented Nov 16, 2024

Copy link
Copy Markdown
Collaborator

Rework test in CURL with base_uri to baseURI?

@michalsnmichalsn added the needs rework Changes requested by reviewer that are still pending label Nov 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs reworkChanges requested by reviewer that are still pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@warmbook@michalsn@ddevsr@neznaika0