refactor: fix phpstan only boolean allowed

[neznaika0]

Description
Fixed all errors like

Only booleans are allowed in ...

I tried to apply the typing adequately during the checks. For a more accurate fix, you need to update the code instead of phpdoc.
It is possible to additionally check for null, false, <empty-string> somewhere
Fixed 92 errors out of 3925

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[michalsn]

Why is null typed into a string so many times? In many cases it is not necessary. I was just looking at the code, I don't know if phpstan forces such typing? In many places it is very strange.

[neznaika0]

See comment @paulbalandan

I think this should also include check against ''.

Short code for check null or empty string. Empty string is incorrect to pass in the parameter.

[michalsn]

@neznaika0 It would be easier if you could respond under the code you're referring to.

Okay, for CLI::print() and CLI::write() it indeed makes sense, but I kindly disagree in other cases.

[neznaika0]

If the value can be null, then why can't it be checked for emptiness as ""? I've made changes where an empty line is also invalid.
So there are cases ?string $value
What other explanation is needed?

[michalsn]

This is not a general conversation about null and empty strings. If you want to justify the disputed change, do it under the code I commented on. It will make our lives easier.

[neznaika0]

@michalsn revert comparison with null

[michalsn]

Thank you!

[paulbalandan]

Thank you, @neznaika0