Uh oh!
There was an error while loading. Please reload this page.
refactor: upgrade to use phpstan 2 and rector 2 - #9322
Merged
paulbalandan merged 3 commits intoDec 15, 2024
Merged
Conversation
5 tasks
samsonasik
commented
Dec 14, 2024
MemberAuthor
/cc @ddevsr |
samsonasik
marked this pull request as draft
December 14, 2024 21:32
samsonasik
commented
Dec 14, 2024
MemberAuthor
phpstan-codeigniter seems stil require phpstan v1, so in there should be updated first: |
samsonasik
commented
Dec 14, 2024
MemberAuthor
Ok, bump to use phpstan-codeigniter 1.5.1 is the way 9b6d9bf |
samsonasik
commented
Dec 14, 2024
MemberAuthor
install seems got codeigniter ^4.5 conflict notice: ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/12333325314/job/34422197398?pr=9322 @paulbalandan@kenjis any idea? |
paulbalandan
commented
Dec 14, 2024
Member
@samsonasik that should be taken care of in #9299, i just need to get @kenjis ' approval |
paulbalandan
commented
Dec 15, 2024
Member
@samsonasik pls rebase in latest develop. probably you would just need to update rector version |
samsonasikforce-pushed
the
refactor-upgrade-phpstan-2-rector-2
branch
from
December 15, 2024 05:33
9b6d9bf to
1147411Comparesamsonasik
commented
Dec 15, 2024
MemberAuthor
Rebased 👍 |
samsonasik
commented
Dec 15, 2024
MemberAuthor
Setup PHP error seems unrelated: |
paulbalandan
marked this pull request as ready for review
December 15, 2024 18:02
paulbalandan
approved these changes
Dec 15, 2024
paulbalandan
left a comment
Member
There was a problem hiding this comment.
I think this is good to go. I'm merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrade to use PHPStan 2 and Rector 2.
Checklist: