refactor: Fix phpstan expr.resultUnused

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.

[neznaika0]

Description
We just ignore the lines, as we expect an exception.
You can set an assignment $s = $entity->ninth, but it seems unnecessary in the test.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This can go to develop branch.

[neznaika0]

I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6?

[samsonasik]

@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop.

[paulbalandan]

What conflicts are you seeing?

[paulbalandan]

As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version.

[neznaika0]

See changes: #9374 (comment)

While I was spending time searching for the cause, the issue was resolved in 4.6

It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches?

[paulbalandan]

Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part.

[paulbalandan]

Thanks so far, @neznaika0 , for cleaning up the baseline.