refactor: Fix phpstan codeigniter.frameworkExceptionInstance

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[neznaika0]

Description
Invoking an FrameworkException using the method only

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Can you tell me why my GA is crashing? It's a copy of this repository.
https://github.com/neznaika0/codeigniter-dev/actions/runs/12687268125/job/35361295486
I tried adding --with-all-dependencies and it installed all the packages.

[samsonasik]

you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias

CodeIgniter4/composer.json

Lines 82 to 87 in 42a00ff

	"extra": {
	"branch-alias": {
	"dev-develop": "4.x-dev",
	"dev-master": "4.x-dev"
	}
	},

/cc @paulbalandan

[neznaika0]

I added all tags and master branch. It didn't help

[paulbalandan]

My best guess is that neznaika0/framework is not the same as codeigniter4/framework.

I think this can be "fixed" by not running the GA in the forks.

[neznaika0]

There seems to be a mistake in applying the rules comment_to_phpdoc

[paulbalandan]

If you have time, pls send a PR to the coding-standard repo adding @phpstan-ignore in the ignored tags of comment_to_phpdoc. I'll gladly merge it.

[neznaika0]

But before that, he ignores @phpstan-ignore Only now it showed up

[paulbalandan]

I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc.

[neznaika0]

Rewrite as phpDoc?

[paulbalandan]

Yes. This is what it looks like:

This is correct because the @var needs to be in a phpdoc so that IDEs can understand that $foo is an int.

-// @var int $foo+/** @var int $foo */
$foo = some_function();

Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to $e2 and changes the comment to a phpdoc.

[github-actions]

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch