Skip to content

chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447

Merged
samsonasik merged 3 commits into
developfrom
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged

chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom
dependabot/composer/rector/rector-2.0.9

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubFeb 10, 2025

Copy link
Copy Markdown
Contributor

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released: Rector 2.0.9

Bugfixes 🐛

  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!

New Features 🥳

  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot added dependencies Pull requests that update external dependencies php labels Feb 10, 2025
@samsonasik

samsonasik commented Feb 10, 2025

Copy link
Copy Markdown
Member

I've re-run rector to apply assertEmpty() when possible 65b71e9

@samsonasik

samsonasik commented Feb 10, 2025

Copy link
Copy Markdown
Member

Ready to merge 👍

@michalsn

michalsn commented Feb 10, 2025

Copy link
Copy Markdown
Member

I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.

We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.

paulbalandan
paulbalandan reviewed Feb 10, 2025
View reviewed changes

@paulbalandanpaulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.

In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.

@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik

samsonasik commented Feb 11, 2025

Copy link
Copy Markdown
Member

@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍

@samsonasik

samsonasik commented Feb 11, 2025

Copy link
Copy Markdown
Member

Ready to merge 👍

michalsn
michalsn approved these changes Feb 11, 2025
View reviewed changes

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@samsonasik

samsonasik commented Feb 11, 2025

Copy link
Copy Markdown
Member

Let's merge 👍

@samsonasik
samsonasik merged commit f4213ab into developFeb 11, 2025
@samsonasik
samsonasik deleted the dependabot/composer/rector/rector-2.0.9 branch February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees

No one assigned

Labels

dependenciesPull requests that update external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 by dependabot[bot] · Pull Request #9447 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 - #9447
Merged
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Feb 11, 2025
Merged
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9#9447
samsonasik merged 3 commits into
developfrom 
dependabot/composer/rector/rector-2.0.9
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubFeb 10, 2025

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released: Rector 2.0.9
Bugfixes 🐛
  • [Php81] Exclude Doctrine ODM MongoDB Document and EmbeddedDocument from ReadOnlyPropertyRector (#6721), Thanks @​mickverm!
  • [PostRector] Handle with FQCN docblock on UnusedImportRemovingPostRector (#6722)
  • Type hint array reduce closure (#6725), Thanks @​peterfox!
New Features 🥳
  • [PHPStan 2.1.3] Add ReflectionAttribute and ReflectionIntersectionType stub for PHPStan 2.1.3 (#6723)
Commits
  • 4393230 Rector 2.0.9
  • a291726 Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67
  • d79d968 Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4
  • 767bb46 Updated Rector to commit 70920b211391beb82fd05c269e6689e50b430988
  • 20f374a Updated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8
  • ead5e52 Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9
1955a33
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@2.0.8...2.0.9)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update external dependencies
php

labels
Feb 10, 2025
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I've re-run rector to apply assertEmpty() when possible 65b71e9
@samsonasik
samsonasik
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
@michalsn
michalsn
commented
Feb 10, 2025

Copy link


Copy Markdown

Member
I have mixed feelings about this rule. Doesn't it work as a check on the empty() function? We try to avoid this function in our code because of the loose comparison it offers. In this case, we also will not know what exactly is returned.
We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules.
paulbalandan
paulbalandan
reviewed
Feb 10, 2025
View reviewed changes
@paulbalandanpaulbalandan
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
@samsonasik
fix Revert "refactor: re-run rector"
1925f69
This reverts commit 65b71e9.
fix: skip rector.php
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
@michalsn@paulbalandan thank you for the reivew, I reverted the change and skip the AssertCountWithZeroToAssertEmptyRector rule 1925f69 👍
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Ready to merge 👍
michalsn
michalsn
approved these changes
Feb 11, 2025
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@samsonasik
samsonasik
commented
Feb 11, 2025

Copy link


Copy Markdown

Member
Let's merge 👍
@samsonasik
samsonasik
merged commit f4213ab
into
developFeb 11, 2025
@samsonasik
samsonasik
deleted the

dependabot/composer/rector/rector-2.0.9

branch
February 11, 2025 07:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@kenjiskenjisAwaiting requested review from kenjis
@paulbalandanpaulbalandanAwaiting requested review from paulbalandan

Assignees


No one assigned


Labels

dependenciesPull requests that update external dependencies

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik@michalsn@paulbalandan