Uh oh!
There was an error while loading. Please reload this page.
fix: added "application/octet-stream" to the "stl" mime type in the M… - #9543
Conversation
Hi there, Franky5831! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
FrancescoCiannavei
commented
Apr 28, 2025
I previously created this pull request but I closed since the commit wasn't verified and created this one. |
michalsn
commented
Apr 28, 2025
Thank you. Please add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.6.1.rst |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
paulbalandan
commented
Apr 29, 2025
Should the |
michalsn
commented
Apr 29, 2025
@paulbalandan Oh, you're right - I forgot about @Franky5831 Can you add it to the config array and also mention it in the changelog? |
FrancescoCiannavei
commented
Apr 29, 2025
Sorry @michalsn I think I lost you, I created a pull request where I edited |
michalsn
left a comment
There was a problem hiding this comment.
This is exactly what I have in mind.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
michalsn
commented
May 1, 2025
Thank you for your first contribution to the CodeIgniter framework @Franky5831 |
Description
I added the "application/octet-stream" to the "stl" mime type in the Mimes config class.
When I upload a stl file the mime type returns as "application/octet-stream" and the
ext_ininput validation returns false.Reference issue: Issue: 9510.
Checklist: