Skip to content

feat: add dns_cache_timeout for option CURLRequest - #9553

Merged
michalsn merged 13 commits into
codeigniter4:4.7from
ddevsr:dns-cache-time-curl
May 15, 2025
Merged

feat: add dns_cache_timeout for option CURLRequest#9553
michalsn merged 13 commits into
codeigniter4:4.7from
ddevsr:dns-cache-time-curl

Conversation

@ddevsr

@ddevsrddevsr commented May 13, 2025

Copy link
Copy Markdown
Collaborator

Description
Options for change default DNS Cache Timeout cURL.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr
ddevsr requested review from michalsn and paulbalandan and removed request for michalsnMay 13, 2025 15:24
@ddevsrddevsr added enhancement PRs that improve existing functionalities 4.7 labels May 13, 2025
michalsn
michalsn approved these changes May 14, 2025
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.7.0.rst
@paulbalandanpaulbalandan changed the title feat: added dns_cache_timeout for option CURLRequestfeat: add dns_cache_timeout for option CURLRequestMay 14, 2025
paulbalandan
paulbalandan reviewed May 14, 2025
View reviewed changes
Comment threadsystem/HTTP/CURLRequest.php Outdated
Comment threadtests/system/HTTP/CURLRequestTest.php Outdated
Comment threaduser_guide_src/source/changelogs/v4.7.0.rst
Comment threaduser_guide_src/source/libraries/curlrequest.rst Outdated
@ddevsr
ddevsrforce-pushed the dns-cache-time-curl branch from 5f71d8f to c3f2f21CompareMay 15, 2025 03:15
@ddevsr
ddevsrforce-pushed the dns-cache-time-curl branch from 369a47b to a48bc8aCompareMay 15, 2025 03:47
@ddevsr
ddevsr requested a review from paulbalandanMay 15, 2025 04:05
paulbalandan
paulbalandan reviewed May 15, 2025
View reviewed changes

@paulbalandanpaulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! Just a minor comment in the doc.

Comment threaduser_guide_src/source/libraries/curlrequest.rst Outdated
@ddevsr
ddevsr requested a review from paulbalandanMay 15, 2025 05:00
paulbalandan
paulbalandan reviewed May 15, 2025
View reviewed changes

@paulbalandanpaulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final touches, and the rest LGTM.

Comment threadtests/system/HTTP/CURLRequestTest.php Outdated
Comment threadtests/system/HTTP/CURLRequestTest.php Outdated
Comment threaduser_guide_src/source/libraries/curlrequest.rst Outdated
ddevsrand others added 3 commits May 16, 2025 00:39
@ddevsr@paulbalandan
Update tests/system/HTTP/CURLRequestTest.php
5094584
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@ddevsr@paulbalandan
Update tests/system/HTTP/CURLRequestTest.php
e3a7be0
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@ddevsr@paulbalandan
Update user_guide_src/source/libraries/curlrequest.rst
ad84b38
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@michalsn
michalsn merged commit f7d6142 into codeigniter4:4.7May 15, 2025
@michalsn

michalsn commented May 15, 2025

Copy link
Copy Markdown
Member

Thank you @ddevsr

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

enhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr@michalsn@paulbalandan