Uh oh!
There was an error while loading. Please reload this page.
fix: remove service dependency from sanitize_filename() helper function - #9560
Conversation
paulbalandan
left a comment
There was a problem hiding this comment.
Should the method be deprecated as it is just an exact copy?
michalsn
commented
May 15, 2025
I was thinking about this because if you look at the methods that are available and the user guide itself, IMO, this method is added a bit by force. On the other hand, it is listed in |
paulbalandan
commented
May 15, 2025
In my opinion, if the |
michalsn
commented
May 17, 2025
With no additional feedback, I've marked |
michalsn
commented
May 18, 2025
Thank you @samsonasik and @paulbalandan |
Description
This PR fixes a bug where the
sanitize_filename()helper function could not be used in CLI requests.The
sanitize_filename()function in the Security helper now contains the logic that was previously in theSecurity::sanitizeFilename()method. The method has been updated to delegate to the helper function, reversing the previous dependency. This change allows the function to be used in CLI requests without relying on the service.Fixes: #9555
Checklist: