refactor: fix various phpstan errors in Log component

[paulbalandan]

Description
Fixing some phpstan errors. Hope I did not break anything.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[michalsn]

Thanks, looks good!

[mjomble]

Looks like it did break something 😁

In isEmpty(), return empty($this->data); was correct, but return $this->data !== []; actually checks for "is not empty".

Also, both this and if (! empty($this->data)) { in collectLogs() assume $this->data is always an array, but it starts out as null.

And ironically, due to this very assumption, it will always remain null 😄

Seems to me like empty() is perfect here, covering both the null and empty array cases.
Does phpstan recommend avoiding it? If so, I wonder why?

[paulbalandan]

Hi @mjomble , please send a PR fixing those. We're moving away from use of empty() as it is a loose check.