Skip to content

refactor: partial fix errors on Email - #9582

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:partial-email-refactor
May 31, 2025
Merged

refactor: partial fix errors on Email#9582
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:partial-email-refactor

Conversation

@paulbalandan

@paulbalandanpaulbalandan commented May 26, 2025

Copy link
Copy Markdown
Member

Description
Partial refactor. The Email class is very big. Hard to follow the code.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandanpaulbalandan added the refactor Pull requests that refactor code label May 26, 2025
michalsn
michalsn reviewed May 26, 2025
View reviewed changes
Comment threadsystem/Email/Email.php
Comment threadsystem/Email/Email.php Outdated
@paulbalandan
paulbalandanforce-pushed the partial-email-refactor branch 3 times, most recently from 06437e3 to b001759CompareMay 27, 2025 11:44
@github-actionsgithub-actionsBot added the stale Pull requests with conflicts label May 31, 2025
@github-actions

This comment was marked as outdated.

Sign in to view
@paulbalandan
paulbalandanforce-pushed the partial-email-refactor branch from b001759 to 2eb35a3CompareMay 31, 2025 16:56
@paulbalandanpaulbalandan removed the stale Pull requests with conflicts label May 31, 2025
@paulbalandan
paulbalandan merged commit 58f6b16 into codeigniter4:developMay 31, 2025
@paulbalandan
paulbalandan deleted the partial-email-refactor branch May 31, 2025 17:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan@michalsn