Skip to content

feat: add option to change default behaviour of JSONFormatter max depth - #9585

Merged
michalsn merged 4 commits into
codeigniter4:4.7from
ddevsr:json-depth-option
May 31, 2025
Merged

feat: add option to change default behaviour of JSONFormatter max depth#9585
michalsn merged 4 commits into
codeigniter4:4.7from
ddevsr:json-depth-option

Conversation

@ddevsr

@ddevsrddevsr commented May 27, 2025•
edited by paulbalandan
Loading

Copy link
Copy Markdown
Collaborator

Description
Added option change behaviour depth JSON Formatter

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsrddevsr added docs needed Pull requests needing documentation write-ups and/or revisions. 4.7 enhancement PRs that improve existing functionalities labels May 27, 2025
@paulbalandan

paulbalandan commented May 27, 2025

Copy link
Copy Markdown
Member

I will merge develop to 4.7 to capture the latest changes in JSONFormatter. Please rebase after that.

@ddevsr
ddevsrforce-pushed the json-depth-option branch from 21ae5d9 to c96e1b0CompareMay 27, 2025 15:52
@ddevsrddevsr removed the docs needed Pull requests needing documentation write-ups and/or revisions. label May 27, 2025
michalsn
michalsn reviewed May 29, 2025
View reviewed changes

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why Psalm is failing - it might be related to recent changes in psalm_autoload.php, but it's unclear. We didn't have any issues before merging into the 4.7 branch. Maybe Paul can help figure it out.

Comment threadapp/Config/Format.php Outdated
Comment threadapp/Config/Format.php Outdated
Comment threadapp/Config/Format.php Outdated
Comment threadsystem/Format/JSONFormatter.php Outdated
Comment threaduser_guide_src/source/changelogs/v4.7.0.rst Outdated
Comment threaduser_guide_src/source/outgoing/api_responses.rst Outdated
@paulbalandanpaulbalandan changed the title feat: added options for change default behaviour depth JSON Formatterfeat: add option to change default behaviour of JSONFormatter max depthMay 30, 2025
@michalsn
michalsn merged commit fa1178d into codeigniter4:4.7May 31, 2025
@michalsn

michalsn commented May 31, 2025

Copy link
Copy Markdown
Member

@ddevsr Thanks!

@ddevsr
ddevsr deleted the json-depth-option branch May 31, 2025 08:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

enhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr@paulbalandan@michalsn