Skip to content

refactor: remove deprecated types in random_string() helper - #9592

Merged
michalsn merged 3 commits into
codeigniter4:4.7from
michalsn:refactor/random-string-types
Jun 3, 2025
Merged

refactor: remove deprecated types in random_string() helper#9592
michalsn merged 3 commits into
codeigniter4:4.7from
michalsn:refactor/random-string-types

Conversation

@michalsn

@michalsnmichalsn commented Jun 3, 2025

Copy link
Copy Markdown
Member

Description
This PR removes deprecated types from the random_string() helper function.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsnmichalsn added refactor Pull requests that refactor code 4.7 labels Jun 3, 2025
paulbalandan
paulbalandan reviewed Jun 3, 2025
View reviewed changes
Comment threadsystem/Helpers/text_helper.php Outdated
Comment threadsystem/Helpers/text_helper.php
Comment threadtests/system/Helpers/TextHelperTest.php Outdated
@github-actionsgithub-actionsBot added the stale Pull requests with conflicts label Jun 3, 2025
michalsnand others added 3 commits June 3, 2025 18:50
@michalsn
michalsnforce-pushed the refactor/random-string-types branch from b5e3712 to 5ae0bf8CompareJune 3, 2025 16:51
@codeigniter4codeigniter4 deleted a comment from github-actionsBotJun 3, 2025
@michalsnmichalsn removed the stale Pull requests with conflicts label Jun 3, 2025
@michalsn
michalsn merged commit 06340ce into codeigniter4:4.7Jun 3, 2025
@michalsn

michalsn commented Jun 3, 2025

Copy link
Copy Markdown
MemberAuthor

Thank you @paulbalandan

@michalsn
michalsn deleted the refactor/random-string-types branch June 16, 2025 18:38
@neznaika0neznaika0 mentioned this pull request Dec 18, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michalsn@paulbalandan