Skip to content

fix: support for multibyte folder names when the app is served from a subfolder - #9615

Merged
michalsn merged 1 commit into
codeigniter4:developfrom
michalsn:fix/multibyte-characters-in-folder-name
Jun 30, 2025
Merged

fix: support for multibyte folder names when the app is served from a subfolder#9615
michalsn merged 1 commit into
codeigniter4:developfrom
michalsn:fix/multibyte-characters-in-folder-name

Conversation

@michalsn

Copy link
Copy Markdown
Member

Description
This PR fixes a bug where folder names containing multibyte (non-ASCII) characters were not correctly resolved by SiteURIFactory::parseRequestURI() when the application was served from a subfolder.

The problem was spotted here: #9613 (comment)

Needs #9613

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsnmichalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 27, 2025
@michalsn
michalsnforce-pushed the fix/multibyte-characters-in-folder-name branch from 9e157f0 to 3b5b6ffCompareJune 30, 2025 05:26
@michalsn
michalsnforce-pushed the fix/multibyte-characters-in-folder-name branch from 3b5b6ff to 06f1944CompareJune 30, 2025 06:04
@michalsn
michalsn merged commit 78f3842 into codeigniter4:developJun 30, 2025
@michalsn

Copy link
Copy Markdown
MemberAuthor

Thank you @samsonasik and @paulbalandan

@michalsn
michalsn deleted the fix/multibyte-characters-in-folder-name branch June 30, 2025 18:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugVerified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@michalsn@samsonasik@paulbalandan