Skip to content

fix: make:test requires 3 inputs after entering an empty class name - #9637

Merged
michalsn merged 3 commits into
codeigniter4:developfrom
paulbalandan:make-test-empty-class
Jul 15, 2025
Merged

fix: make:test requires 3 inputs after entering an empty class name#9637
michalsn merged 3 commits into
codeigniter4:developfrom
paulbalandan:make-test-empty-class

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Ref: #9635 (review)

To verify the bug, try running make:test with no argument. On the next prompt, input the desired class. It will prompt again for another try. Try again for 2 more times.

$ php spark make:testCodeIgniter v4.6.1 Command Line Tool - Server Time: 2025-07-15 18:22:09 UTC+00:00Test class name : Foo/BarTest class name : Foo/BarTest class name : Foo/BarFile created: ROOTPATH/tests/Foo/BarTest.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandanpaulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 15, 2025
@paulbalandan
paulbalandanforce-pushed the make-test-empty-class branch from 20fc556 to 0582087CompareJuly 15, 2025 18:29

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@michalsn
michalsn merged commit 8c7ab80 into codeigniter4:developJul 15, 2025
48 checks passed
@paulbalandan
paulbalandan deleted the make-test-empty-class branch July 15, 2025 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugVerified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@michalsn@datamweb