Skip to content

refactor: update preload script to exclude util_bootstrap - #9649

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
ddevsr:patch-3
Jul 30, 2025
Merged

refactor: update preload script to exclude util_bootstrap#9649
paulbalandan merged 1 commit into
codeigniter4:developfrom
ddevsr:patch-3

Conversation

@ddevsr

@ddevsrddevsr commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

Description
Followup preload #9562

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsrddevsr changed the title fix: update preload exlude util_bootstrapfix: update preload exclude util_bootstrapJul 29, 2025
@ddevsrddevsr added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 29, 2025
@paulbalandan

paulbalandan commented Jul 29, 2025

Copy link
Copy Markdown
Member

How can I test this?

@ddevsr

ddevsr commented Jul 29, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Use v4.6.2 with current condition

@michalsn

michalsn commented Jul 29, 2025

Copy link
Copy Markdown
Member

Could you provide more context? Is this actually a fix or just an update of the preload script? Why is this needed?

Sorry, but I don't have opcache installed locally on this machine, to check what is going on.

@ddevsr

ddevsr commented Jul 29, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Today, i have upgraded on production from v4.6.1 with running opcache preload to v4.6.2. Related to this files in my fpm service, check on development server same result. Only upgrade version (with cache removed)

@ddevsr

ddevsr commented Jul 29, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Actual just update preload i think, i already exclude for now, Not tested more how actually works in utils_bootstrap

michalsn
michalsn approved these changes Jul 29, 2025
View reviewed changes

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, util_bootstrap.php is a newly created file and isn't used by web apps, so I think it's reasonable to exclude it.

@michalsnmichalsn changed the title fix: update preload exclude util_bootstraprefactor: update preload exclude util_bootstrapJul 29, 2025
@michalsnmichalsn added refactor Pull requests that refactor code and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Jul 29, 2025
@paulbalandanpaulbalandan changed the title refactor: update preload exclude util_bootstraprefactor: update preload script to exclude util_bootstrapJul 29, 2025
@paulbalandan
paulbalandan merged commit 2f6ca33 into codeigniter4:developJul 30, 2025
8 checks passed
@paulbalandan

paulbalandan commented Jul 30, 2025

Copy link
Copy Markdown
Member

Thank you @ddevsr

@ddevsr
ddevsr deleted the patch-3 branch July 30, 2025 01:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr@paulbalandan@michalsn