Skip to content

feat: migrations lock - #9660

Merged
paulbalandan merged 5 commits into
codeigniter4:4.7from
michalsn:feat/migration-lock
Aug 17, 2025
Merged

feat: migrations lock#9660
paulbalandan merged 5 commits into
codeigniter4:4.7from
michalsn:feat/migration-lock

Conversation

@michalsn

@michalsnmichalsn commented Aug 4, 2025

Copy link
Copy Markdown
Member

Description
This PR introduces a database-agnostic locking system for migrations. It guarantees consistent behavior across all supported databases. Lock cleanup is safe and automatically handled through finally blocks, and there are no modifications to the public API, ensuring full compatibility with existing workflows.

Closes#9646

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsnmichalsn added enhancement PRs that improve existing functionalities 4.7 labels Aug 4, 2025
@paulbalandan

paulbalandan commented Aug 4, 2025

Copy link
Copy Markdown
Member

This should also need to be added in the upgrading under Config section telling people to add the new property.

@michalsn

michalsn commented Aug 4, 2025

Copy link
Copy Markdown
MemberAuthor

Updated.

paulbalandan
paulbalandan reviewed Aug 5, 2025
View reviewed changes
Comment threadsystem/Database/MigrationRunner.php
paulbalandan
paulbalandan approved these changes Aug 5, 2025
View reviewed changes

@paulbalandanpaulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@michalsnmichalsn linked an issue Aug 8, 2025 that may be closed by this pull request
Feat: Migration lock at the start of migration in CodeIgniter 4 #9646
Closed
@michalsnmichalsn mentioned this pull request Aug 13, 2025
Merged
5 tasks
@github-actionsgithub-actionsBot added the stale Pull requests with conflicts label Aug 13, 2025
@michalsnmichalsn removed the stale Pull requests with conflicts label Aug 13, 2025
@codeigniter4codeigniter4 deleted a comment from github-actionsBotAug 13, 2025
@paulbalandan
paulbalandan merged commit 500d4ad into codeigniter4:4.7Aug 17, 2025
50 checks passed
@paulbalandan

paulbalandan commented Aug 17, 2025

Copy link
Copy Markdown
Member

Thank you, @michalsn

@michalsn
michalsn deleted the feat/migration-lock branch August 20, 2025 06:13
@neznaika0neznaika0 mentioned this pull request Dec 11, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandanpaulbalandanpaulbalandan approved these changes
+1 more reviewer
@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Migration lock at the start of migration in CodeIgniter 4

3 participants

@michalsn@paulbalandan@datamweb