Skip to content

refactor: Update phpDoc typing - #9661

Merged
paulbalandan merged 2 commits into
codeigniter4:developfrom
neznaika0:refactor/phpstan-types
Aug 7, 2025
Merged

refactor: Update phpDoc typing#9661
paulbalandan merged 2 commits into
codeigniter4:developfrom
neznaika0:refactor/phpstan-types

Conversation

@neznaika0

@neznaika0neznaika0 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description
The main task was to update esc(), but a little more was done 😄
We can use templates (DB, cookies) for dependent functions, but then I might make a mistake with the imports.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

ddevsr
ddevsr reviewed Aug 5, 2025
View reviewed changes
Comment threadtests/system/CommonFunctionsTest.php
paulbalandan
paulbalandan reviewed Aug 5, 2025
View reviewed changes
Comment threadsystem/Common.php Outdated
Comment threadsystem/Helpers/cookie_helper.php Outdated
@neznaika0
neznaika0force-pushed the refactor/phpstan-types branch from 0c6b490 to 07d5ac4CompareAugust 6, 2025 06:06
@paulbalandan
paulbalandan merged commit fb0ea4b into codeigniter4:developAug 7, 2025
49 checks passed
@paulbalandan

paulbalandan commented Aug 7, 2025

Copy link
Copy Markdown
Member

Thank you @neznaika0

@neznaika0
neznaika0 deleted the refactor/phpstan-types branch August 7, 2025 11:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes
+1 more reviewer
@ddevsrddevsrddevsr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neznaika0@paulbalandan@michalsn@ddevsr