Skip to content

test: remove useless DotEnvTest test - #9673

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:useless-dotenv-test
Aug 12, 2025
Merged

test: remove useless DotEnvTest test#9673
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:useless-dotenv-test

Conversation

@paulbalandan

@paulbalandanpaulbalandan commented Aug 11, 2025

Copy link
Copy Markdown
Member

Description
The test is useless as it does not test the class itself but PHP's strict typing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandanpaulbalandan added the testing Pull requests that changes tests only label Aug 11, 2025
@paulbalandanpaulbalandan mentioned this pull request Aug 11, 2025
Merged
5 tasks
@github-actionsgithub-actionsBot added the stale Pull requests with conflicts label Aug 12, 2025
@github-actions

This comment was marked as resolved.

Sign in to view
@paulbalandanpaulbalandan removed the stale Pull requests with conflicts label Aug 12, 2025
@paulbalandan
paulbalandan merged commit 509ed87 into codeigniter4:developAug 12, 2025
86 of 99 checks passed
@paulbalandan
paulbalandan deleted the useless-dotenv-test branch August 12, 2025 17:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

Assignees

No one assigned

Labels

testingPull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan@michalsn