Uh oh!
There was an error while loading. Please reload this page.
fix: prevent non-shared DB instances from polluting shared cache - #9679
Merged
Conversation
neznaika0
approved these changes
Aug 13, 2025
neznaika0
left a comment
Contributor
There was a problem hiding this comment.
It's been wrong for so long...
paulbalandan
left a comment
Member
There was a problem hiding this comment.
I think this bug is one of the reasons why we cannot randomize the tests.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
paulbalandan
approved these changes
Aug 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
michalsn
commented
Aug 13, 2025
MemberAuthor
Thank you @paulbalandan and @neznaika0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where non-shared database instances were incorrectly stored in the shared instances cache, causing modifications to non-shared instances to affect subsequent shared connections.
Fixes#9678
Checklist: