Skip to content

refactor: remove imagedestroy has no effect since PHP 8.0 - #9688

Merged
michalsn merged 2 commits into
codeigniter4:4.7from
ddevsr:remove-imagedestroy
Aug 19, 2025
Merged

refactor: remove imagedestroy has no effect since PHP 8.0#9688
michalsn merged 2 commits into
codeigniter4:4.7from
ddevsr:remove-imagedestroy

Conversation

@ddevsr

Copy link
Copy Markdown
Collaborator

Description
Based on php/php-src#19454 and related to #9664

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsrddevsr added refactor Pull requests that refactor code 4.7 labels Aug 19, 2025
Comment threadsystem/Images/Handlers/GDHandler.php
@ddevsr
ddevsr requested a review from michalsnAugust 19, 2025 12:30
@michalsn
michalsn merged commit 3c10cc1 into codeigniter4:4.7Aug 19, 2025
47 of 48 checks passed
@michalsn

Copy link
Copy Markdown
Member

Thank you @ddevsr

@ddevsr
ddevsr deleted the remove-imagedestroy branch August 19, 2025 15:38
@michalsnmichalsn mentioned this pull request Aug 19, 2025
17 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorPull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr@michalsn@paulbalandan