Skip to content

chore: bump minimum required PHP 8.2 - #9701

Merged
michalsn merged 14 commits into
codeigniter4:4.7from
ddevsr:minimal-php82
Sep 5, 2025
Merged

chore: bump minimum required PHP 8.2#9701
michalsn merged 14 commits into
codeigniter4:4.7from
ddevsr:minimal-php82

Conversation

@ddevsr

@ddevsrddevsr commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

Description
See #9667 (review)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsrddevsr mentioned this pull request Sep 3, 2025
17 tasks
@ddevsrddevsr added 4.7 refactor Pull requests that refactor code labels Sep 3, 2025
@ddevsrddevsr mentioned this pull request Sep 3, 2025
5 tasks
@samsonasik

Copy link
Copy Markdown
Member

Rector php sets need to be updated to php82: true

->withPhpSets(php81: true)

Comment threadadmin/starter/composer.json Outdated
Comment threadsystem/HTTP/Files/UploadedFileInterface.php Outdated
Comment threadsystem/HTTP/Files/UploadedFile.php Outdated
@ddevsr

Copy link
Copy Markdown
CollaboratorAuthor

@samsonasik Suggestion change in rector set PHP 8.2 can be split another PR?

@paulbalandanpaulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also set up an issue tracking what PHP 8.2 features we can adopt? For one I can think of is the SensitiveParameter attribute.

@neznaika0

neznaika0 commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

See here:

phpVersion: 80100

and here:
// @TODO remove this after dropping PHP 8.1 support.

Are we changing it?

@neznaika0

neznaika0 commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@neznaika0neznaika0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the rule for readonly, but when a writeable property appears, you need to return readonly for the property. We can forget about it.
There are phpstan errors. Okay, we'll fix it later.

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're making these detailed updates, can you also edit warning secion in the README.md and update the line:

- The end of life date for PHP 8.1 will be December 31, 2025.

as well as add EOL for PHP 8.2? Thanks.

@ddevsr

ddevsr commented Sep 4, 2025

Copy link
Copy Markdown
CollaboratorAuthor

When version release 4.7 same as release PHP 8.5 GA, i'll make like this

- The end of life date for PHP 8.1 was December 31, 2025.
- The end of life date for PHP 8.2 will be December 31, 2026.

@ddevsr
ddevsr requested a review from michalsnSeptember 4, 2025 06:37
@michalsn
michalsn merged commit fca548d into codeigniter4:4.7Sep 5, 2025
50 checks passed
@michalsn

Copy link
Copy Markdown
Member

Thank you @ddevsr

@ddevsr
ddevsr deleted the minimal-php82 branch September 5, 2025 06:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorPull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ddevsr@samsonasik@neznaika0@michalsn@paulbalandan