Uh oh!
There was an error while loading. Please reload this page.
feat: added async & persistent options to Cache Redis - #9792
Conversation
Uh oh!
There was an error while loading. Please reload this page.
No tests required? Change config in https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/libraries/caching.rst#redis-caching |
Uh oh!
There was an error while loading. Please reload this page.
michalsn
left a comment
There was a problem hiding this comment.
PHPRedis can also support the persistent option, so we should add it there too via pconnect().
The async option should note that it is used only with Predis.
Preferably, all these new options should be mentioned here: https://codeigniter.com/user_guide/libraries/caching.html#redis-caching
We could introduce a separate configuration parameter for Predis in the config and switch to using new Redis() in the PHPRedis implementation. This would allow us to support all available options in both clients without worrying about missing or incompatible parameters. However, this change would introduce a minor BC break. Thoughts?
async & persistent options to cache predisasync & persistent options to Cache RedisAdded for redis handler too. I want make support Sentinel, but for next PR. Maybe separate config in that PR |
neznaika0
left a comment
There was a problem hiding this comment.
I don't use Redis, but it looks good.
ddevsr
commented
Nov 10, 2025
PR #9793 for |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
michalsn
left a comment
There was a problem hiding this comment.
Looks good, thanks!
PHPStan errors are not related.
Uh oh!
There was an error while loading. Please reload this page.
michalsn
commented
Nov 19, 2025
@ddevsr The |
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
7e3f107 to
7385984CompareUh oh!
There was an error while loading. Please reload this page.
michalsn
commented
Nov 21, 2025
Thank you @ddevsr! |
Description
Added config item to Redis in
Cache.Parameter:
asyncandpersistentconfig item to predis handler.persistentconfig item to redis handler.Checklist: