Skip to content

fix: disable echo in the preload file - #9825

Merged
michalsn merged 1 commit into
codeigniter4:developfrom
michalsn:fix/preload-no-echo
Dec 6, 2025
Merged

fix: disable echo in the preload file#9825
michalsn merged 1 commit into
codeigniter4:developfrom
michalsn:fix/preload-no-echo

Conversation

@michalsn

@michalsnmichalsn commented Dec 5, 2025

Copy link
Copy Markdown
Member

Description
This PR updates the sample preload.php by commenting out the debug echo line and adding a note that preload scripts must not produce output in real use.

Closes#9822

Fixes#9821

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsnmichalsn added bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only labels Dec 5, 2025
@michalsnmichalsn mentioned this pull request Dec 5, 2025
Closed
5 tasks
@michalsn
michalsn merged commit 733dea8 into codeigniter4:developDec 6, 2025
8 checks passed
@michalsn

michalsn commented Dec 6, 2025

Copy link
Copy Markdown
MemberAuthor

Thank you for the review.

@michalsn
michalsn deleted the fix/preload-no-echo branch December 10, 2025 13:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

bugVerified issues on the current code behavior or pull requests that will fix themdocumentationPull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: preload.php has an echo statement in it that messes up spark command output

2 participants

@michalsn@paulbalandan