Skip to content

refactor: complete QueryInterface - #9892

Merged
paulbalandan merged 1 commit into
codeigniter4:4.7from
paulbalandan:complete-query-interface
Jan 18, 2026
Merged

refactor: complete QueryInterface#9892
paulbalandan merged 1 commit into
codeigniter4:4.7from
paulbalandan:complete-query-interface

Conversation

@paulbalandan

@paulbalandanpaulbalandan commented Jan 17, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Adds missing getOriginalQuery() method to interface
  • Adds native parameter and return types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandanpaulbalandan added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.7 labels Jan 17, 2026
@paulbalandan
paulbalandanforce-pushed the complete-query-interface branch from 8de7297 to 8561f53CompareJanuary 18, 2026 09:23
@paulbalandan

paulbalandan commented Jan 18, 2026

Copy link
Copy Markdown
MemberAuthor

Oops, that went wrong. 😅

@paulbalandan
paulbalandanforce-pushed the complete-query-interface branch 2 times, most recently from bb60a8e to eafa7c9CompareJanuary 18, 2026 09:43
neznaika0
neznaika0 suggested changes Jan 18, 2026
View reviewed changes
Comment threadsystem/Database/QueryInterface.php
@paulbalandan
paulbalandanforce-pushed the complete-query-interface branch from eafa7c9 to ab2235aCompareJanuary 18, 2026 10:00
@paulbalandan
paulbalandan merged commit 4685507 into codeigniter4:4.7Jan 18, 2026
50 checks passed
@paulbalandan
paulbalandan deleted the complete-query-interface branch January 18, 2026 14:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
+1 more reviewer
@neznaika0neznaika0neznaika0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@michalsn@neznaika0