Uh oh!
There was an error while loading. Please reload this page.
refactor: make random-order CLI tests deterministic - #9998
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
paulbalandan
approved these changes
Feb 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
michalsn
commented
Feb 24, 2026
MemberAuthor
Thanks! |
38 tasks
paulbalandan
commented
Feb 28, 2026
Member
I am creating a test that verifies the components are truly running now in random, and this CLI test randomly fails: PHPUnit 11.5.55 by Sebastian Bergmann and contributors.Runtime: PHP 8.5.3 with Xdebug 3.5.1Configuration: /Users/paul/Workspace/CodeIgniter4/phpunit.xml.distRandom Seed: 1772303183F.stty: stdin isn't a terminal...........stty: stdin isn't a terminal........stty: stdin isn't a terminal............stty: stdin isn't a terminal.....stty: stdin isn't a terminalstty: stdin isn't a terminal..stty: stdin isn't a terminal..stty: stdin isn't a terminal..stty: stdin isn't a terminal..................stty: stdin isn't a terminal... 65 / 72 ( 90%).stty: stdin isn't a terminal.stty: stdin isn't a terminal..... 72 / 72 (100%)Time: 00:03.497, Memory: 26.00 MBThere was 1 failure:1) CodeIgniter\CLI\CLITest::testWriteForegroundWithColorAfterFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@-'�[0;31mred �[0m�[0;32mgreen�[0m+'+�[0;31mred �[0m�[0;32mgreen�[0m '/Users/paul/Workspace/CodeIgniter4/tests/system/CLI/CLITest.php:367FAILURES!Tests: 72, Assertions: 159, Failures: 1.Generating code coverage report in Clover XML format ... done [00:00.521]Generating code coverage report in HTML format ... done [00:03.959] |
michalsn
commented
Mar 1, 2026
MemberAuthor
I will try to look into this - thanks! |
5 tasks
michalsn
commented
Mar 1, 2026
MemberAuthor
I have sent a PR with a fix: #10014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR stabilizes CLI tests under random execution order and fixes some static analysis types.
Ref: #9968
Checklist: