Rector Version

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.

[MGatner]

Description

• Expands Rector version to be backwards-compatible to 0.19
• Normalizes the Composer config

[samsonasik]

I prefer the bump of using 1.0.0 tbh, with reasons:

• there is no bc break on 0.19 vs 1.0.0 afaik
• rector rely on phpstan, and phpstan requirement maybe bumped on 1.0.0, as phpstan can have bc break on its extension (eg: phpdoc-parser), so keep up with latest 1.0.0 is better imo

but I will let you guys decide :)

[MGatner]

The problem is that DevKit will be blocked for any projects that currently require Rector directly - and considering that we just recently added Rector to Composer that's probably the case for 90% of projects.

[MGatner]

In general: I believe we should be allowing Composer to handle dependencies. Since there is nothing in this project (e.g. the Rector config templates) that is incompatible with ^0.19 then we describe this project's compatibility, rather than prescribing how we want developers to use it.