Skip to content

chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81

Closed
dependabot[bot] wants to merge 1 commit into
developfrom
dependabot/composer/rector/rector-0.17.0
Closed

chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom
dependabot/composer/rector/rector-0.17.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubJun 2, 2023

Copy link
Copy Markdown
Contributor

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released Rector 0.17

Preparing for Rector 1.0

In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.

This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead

We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules

  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)

To see how to refactor to StmtsAwareInterface, check these PRs:

  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)

Add/remove nodes directly 👍

The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.

  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)

New Features 🥳

  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!

Bugfixes 🐛

  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)

... (truncated)

Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jun 2, 2023
@samsonasik

samsonasik commented Jun 2, 2023

Copy link
Copy Markdown
Member

Removed rule seems not checked on workflow

settings/rector.php

Line 6 in 854224b

useRector\CodeQuality\Rector\For_\ForToForeachRector;

due to workflow require rector ^0.15

settings/.github/workflows/rector.yml

Line 66 in 854224b

composer global require --dev rector/rector:^0.15

@samsonasiksamsonasik self-assigned this Jun 2, 2023
@samsonasiksamsonasik mentioned this pull request Jun 2, 2023
Closed
@kenjis

kenjis commented Jun 2, 2023

Copy link
Copy Markdown
Member

@samsonasik Do you think the current workflow (below) is the best practice?

  • set fixed rector version in composer.json
  • update the version with dependabot

@samsonasik

samsonasik commented Jun 2, 2023

Copy link
Copy Markdown
Member

Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this

@kenjis

kenjis commented Jun 2, 2023

Copy link
Copy Markdown
Member

Okay. It seems rector.yml in devkit does not follow the practice.
I will fix it.

@kenjiskenjis mentioned this pull request Jun 2, 2023
Merged
@kenjis

kenjis commented Jun 2, 2023

Copy link
Copy Markdown
Member

Sent PR #82 for this repository.

@dependabot@github

dependabotBot commented on behalf of githubJun 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Superseded by #83.

@dependabotdependabotBot closed this Jun 15, 2023
@dependabot
dependabotBot deleted the dependabot/composer/rector/rector-0.17.0 branch June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 by dependabot[bot] · Pull Request #81 · codeigniter4/settings · GitHub
Skip to content
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0 - #81
Closed
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Closed
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0#81
dependabot[bot] wants to merge 1 commit into
developfrom 
dependabot/composer/rector/rector-0.17.0
Conversation
@dependabot
@dependabotdependabotBot
commented
on behalf of githubJun 2, 2023

Copy link


Copy Markdown

Contributor
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Released Rector 0.17
Preparing for Rector 1.0
In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.
This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead
We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules
  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)
To see how to refactor to StmtsAwareInterface, check these PRs:
  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)
Add/remove nodes directly 👍
The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.
  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)
New Features 🥳
  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!
Bugfixes 🐛
  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)
... (truncated)
Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot
chore(deps-dev): update rector/rector requirement from 0.16.0 to 0.17.0
7572d22
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotBot
added

dependencies
Pull requests that update a dependency file
php
Pull requests that update Php code
labels
Jun 2, 2023
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Removed rule seems not checked on workflow
settings/rector.php

Line 6
in
854224b
useRector\CodeQuality\Rector\For_\ForToForeachRector; 
due to workflow require rector ^0.15
settings/.github/workflows/rector.yml

Line 66
in
854224b
 composer global require --dev rector/rector:^0.15
@samsonasiksamsonasik
self-assigned this
Jun 2, 2023
@samsonasiksamsonasik
mentioned this pull request
Jun 2, 2023
 Closed

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
@samsonasik Do you think the current workflow (below) is the best practice?
  • set fixed rector version in composer.json
  • update the version with dependabot
@samsonasik
samsonasik
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Using pinned version and update with dependabot, like in CodeIgniter repo is the best imo, not sure why it use global require for this
@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Okay. It seems rector.yml in devkit does not follow the practice.

I will fix it.
@kenjiskenjis
mentioned this pull request
Jun 2, 2023
 Merged

@kenjis
kenjis
commented
Jun 2, 2023

Copy link


Copy Markdown

Member
Sent PR #82 for this repository.
@dependabot@github
dependabotBot
commented
on behalf of githubJun 15, 2023

Copy link


Copy Markdown

ContributorAuthor
Superseded by #83.
@dependabotdependabotBot
closed this
Jun 15, 2023
@dependabot
dependabotBot
deleted the

dependabot/composer/rector/rector-0.17.0

branch
June 15, 2023 08:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@samsonasiksamsonasik

Labels

dependenciesPull requests that update a dependency filephpPull requests that update Php code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik@kenjis