Skip to content

fix: Update active date only for users activated and not banned. - #1184

Open
warcooft wants to merge 4 commits into
codeigniter4:developfrom
warcooft:feat-adjust-active-date
Open

fix: Update active date only for users activated and not banned.#1184
warcooft wants to merge 4 commits into
codeigniter4:developfrom
warcooft:feat-adjust-active-date

Conversation

@warcooft

@warcooftwarcooft commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Description
See #1179 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamwebdatamweb changed the title feat: Update active date only for users activated and not banned.fix: Update active date only for users activated and not banned.Aug 26, 2024
@datamwebdatamweb added the bug Something isn't working label Aug 26, 2024

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@kenjiskenjis added the tests needed Pull requests that need tests label Aug 26, 2024
@kenjis

Copy link
Copy Markdown
Member

Because the existing PHPUnit tests do not fail, there seems no test code for recordActiveDate.
I would like you to add test code:

  • does not update active date for a user that is not activated
  • does not update active date for a user that is banned

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingtests neededPull requests that need tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@warcooft@kenjis@datamweb