Uh oh!
There was an error while loading. Please reload this page.
feat: add shield:model command - #558
Conversation
Uh oh!
There was an error while loading. Please reload this page.
MGatner
left a comment
There was a problem hiding this comment.
Renaming it MyUserModel means that factories won't pick it up automatically when searching for UserModel. This seems a loss to me, maybe not for the library itself but for any supporting code.
kenjis
commented
Dec 14, 2022
|
kenjis
commented
Dec 14, 2022
Oh, I get an error if I specify |
lonnieezell
left a comment
There was a problem hiding this comment.
When I tried with UserModel as the generated filename, I think the only issue was the class name conflict. I've made suggestions here to fix that in the code (though not the docs).
I think this will fix @MGatner concerns, which I agree with.
Other than that, my only suggestion might be to provide a default classname at the cli prompt.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ffcce42 to
718dd4eCompare
MGatner
left a comment
There was a problem hiding this comment.
I haven't run this but the code looks good. Thanks for making that change.
lonnieezell
left a comment
There was a problem hiding this comment.
Looks great. Thanks for taking this one over.
Uh oh!
There was an error while loading. Please reload this page.
datamweb
commented
Jan 4, 2023
@kenjis waiting for you. Did your worries go away? |
Uh oh!
There was an error while loading. Please reload this page.
Supersedes and closes#491