refactor: validation rules - #861

Merged
kenjis merged 11 commits into
codeigniter4:developfrom
kenjis:refactor-validation-rules
Sep 30, 2023
Merged

refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom
kenjis:refactor-validation-rules

Conversation

@kenjis

@kenjiskenjis commented Sep 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

  • put validation rules into the ValidationRules class
  • make password rules reusable

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added the refactor Pull requests that refactor code label Sep 27, 2023
@kenjis
kenjis marked this pull request as draft September 28, 2023 02:15
@kenjis
kenjisforce-pushed the refactor-validation-rules branch from 81c5165 to 7414fb3CompareSeptember 28, 2023 02:23
@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174

@kenjis
kenjisforce-pushed the refactor-validation-rules branch 2 times, most recently from f0070f5 to 7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37

@kenjis

kenjis commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I separated the Composer cache for lowest dependencies, but still got No space left on device.

Screenshot 2023-09-28 12 13 08

Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861

@paulbalandan

paulbalandan commented Sep 28, 2023

Copy link
Copy Markdown
Member

There is a sample workflow that deletes the used cache of merged PRs. We can use that.

@paulbalandan

paulbalandan commented Sep 28, 2023

Copy link
Copy Markdown
Member

Also, we can unify the naming of caches so that it will not create numerous caches.

@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

@paulbalandan What do you mean?
Why No space left on device occurs? How can we free the disk space?

@paulbalandan

paulbalandan commented Sep 28, 2023

Copy link
Copy Markdown
Member

We can manually delete the used cache for merged PRs.

image

Just click on the trash icon on the branches with refs/pull/<PR no.>/merge

@paulbalandan

paulbalandan commented Sep 28, 2023

Copy link
Copy Markdown
Member

We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries

@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

Okay, I will remove cache manually.

$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}

@kenjis

kenjis commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I removed some caches, but the cache usage is the same.

$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}

Updated.

$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}

@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

Again No space left on device.

Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861

@kenjiskenjis added the help wanted Extra attention is needed label Sep 28, 2023
@kenjis
kenjisforce-pushed the refactor-validation-rules branch 3 times, most recently from 67c7c1d to b319800CompareSeptember 28, 2023 04:45
@kenjis

kenjis commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861

@kenjiskenjis removed the help wanted Extra attention is needed label Sep 28, 2023
@kenjiskenjis mentioned this pull request Sep 28, 2023
Merged
1 task
@kenjis
kenjisforce-pushed the refactor-validation-rules branch from b319800 to a54e614CompareSeptember 28, 2023 05:06
@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

I created a new PR for GitHub Actions. #863

@kenjis
kenjis marked this pull request as ready for review September 28, 2023 05:07
@kenjiskenjis mentioned this pull request Sep 28, 2023
Merged
1 task
@kenjis
kenjisforce-pushed the refactor-validation-rules branch from a54e614 to 7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb reviewed Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
* --------------------------------------------------------------------
*
* @var string[]
* Do not use string rules like `required|valid_email`.

@datamwebdatamwebSep 29, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,
shouldn't the changes be applied to the documentation?

// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...

@kenjiskenjisSep 30, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kenjis
kenjisforce-pushed the refactor-validation-rules branch from 7a680c8 to 8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb approved these changes Sep 30, 2023
View reviewed changes

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.

@kenjis
kenjis merged commit 1d9a659 into codeigniter4:developSep 30, 2023
@kenjis
kenjis deleted the refactor-validation-rules branch September 30, 2023 07:28
@sammyskillssammyskills mentioned this pull request Sep 30, 2023
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
refactor: validation rules - #861
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Sep 30, 2023
Merged
refactor: validation rules#861
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-validation-rules
Conversation
@kenjis
@kenjiskenjis
commented
Sep 27, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
  • put validation rules into the ValidationRules class
  • make password rules reusable
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Sep 27, 2023
@kenjis
kenjis
marked this pull request as draft
September 28, 2023 02:15
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
81c5165 to
7414fb3CompareSeptember 28, 2023 02:23
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
 - Downloading rector/rector (0.18.4)
Failed to download rector/rector from dist: curl error 23 while downloading https://codeload.github.com/rectorphp/rector/legacy.zip/d99a91176b7eb7f2b6d509a6486b3661c6dfd370: Failure writing output to destination
Now trying to download from source
- Syncing rector/rector (0.18.4) into cache
The disk hosting /home/runner/.composer has less than 100MiB of free space, this may be the cause of the following exception
Error: Failed to execute git clone --mirror -- '***github.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git/'
Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-rectorphp-rector.git'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
In Git.php line 472:
Failed to execute git clone --mirror -- '***gi thub.com/rectorphp/rector.git' '/home/runner/.cache/composer/vcs/https---gi thub.com-rectorphp-rector.git/' Cloning into bare repository '/home/runner/.cache/composer/vcs/https---gith ub.com-rectorphp-rector.git'... fatal: write error: No space left on device fatal: fetch-pack: invalid index-pack output update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
Error: Process completed with exit code 1.

https://github.com/codeigniter4/shield/actions/runs/6323482106/job/17200933174
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
2 times, most recently
from
f0070f5 to
7f0d5b3CompareSeptember 28, 2023 03:02
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
The composer cache was 49MB.
Screenshot 2023-09-28 11 53 37
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I separated the Composer cache for lowest dependencies, but still got No space left on device.
Screenshot 2023-09-28 12 13 08
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 6286182 of 18869094 (33.3%), 6.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/6478a5f4-548a-4525-8b7d-f12073007c27/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 2560 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/73043d58-15df-45b3-8b59-71fd6d300ffa_b5bf44b0-6ed1-5922-4ec3-7240bc7b5754_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203006457?pr=861
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
There is a sample workflow that deletes the used cache of merged PRs. We can use that.
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Also, we can unify the naming of caches so that it will not create numerous caches.
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@paulbalandan What do you mean?

Why No space left on device occurs? How can we free the disk space?
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can manually delete the used cache for merged PRs.
image
Just click on the trash icon on the branches with refs/pull/<PR no.>/merge
@paulbalandan
paulbalandan
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We can use this sample workflow to delete the caches of merged PRs.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Okay, I will remove cache manually.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I removed some caches, but the cache usage is the same.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 173837775, "active_caches_count": 61}
Updated.
$ gh api -H "Accept: application/vnd.github+json""/repos/codeigniter4/shield/actions/cache/usage"{ "full_name": "codeigniter4/shield", "active_caches_size_in_bytes": 119023390, "active_caches_count": 37}
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
Again No space left on device.
Run actions/cache@v3
with:
path: /home/runner/.cache/composer/files
key: Linux-composer-7c03de2df306f9299d0172425aef98e930e92b62f2384a646a9ef79f9b2d934f-
restore-keys: Linux-composer-
enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
env:
COMPOSER_PROCESS_TIMEOUT: 0
COMPOSER_NO_INTERACTION: 1
COMPOSER_NO_AUDIT: 1
COMPOSER_AUTH: {"github-oauth": {"github.com": "***"}}
COMPOSER_CACHE_FILES_DIR: /home/runner/.cache/composer/files
Received 0 of 18869094 (0.0%), 0.0 MBs/sec
Cache Size: ~18 MB (18869094 B)
/usr/bin/tar -xf /home/runner/work/_temp/c47b14a5-78f2-4467-82cb-f0667f0a201d/cache.tzst -P -C /home/runner/work/shield/shield --use-compress-program unzstd
/usr/bin/tar: ../../../.cache/composer/files/rector/rector/5e59ef15f1b731d0d8daed7342cd64a8b40cc94b.zip: Wrote only 8704 of 10240 bytes
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/language-server-protocol/bee555c8048b240c2c2f28255fef8f3efc814e2c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/felixfbecker/advanced-json-rpc/ee93f6a030a8ec4909ae17405ed90c75f9d0c59c.zip: Cannot open: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../.cache/composer/files/amphp: Cannot mkdir: No space left on device
/usr/bin/tar: ../../../.cache/composer/files/amphp/byte-stream/24823ac0e49e56800f97cb0f4e852334fc3a60e0.zip: Cannot open: No such file or directory
Error: Failed to create step summary using 'GITHUB_STEP_SUMMARY': No space left on device : '/home/runner/runners/2.309.0/_diag/Worker_20230928-040404-utc.log'
Error: No space left on device : '/home/runner/runners/2.309.0/_diag/pages/1db4ff28-32bb-43f4-b866-6074ce04f994_351f6ddc-12f9-5119-6975-2ab1c53114b8_1.log'

https://github.com/codeigniter4/shield/actions/runs/6334017276/job/17203911560?pr=861
@kenjiskenjis
added
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
3 times, most recently
from
67c7c1d to
b319800CompareSeptember 28, 2023 04:45
@kenjis
kenjis
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Screenshot 2023-09-28 13 58 32
https://github.com/codeigniter4/shield/actions/runs/6334642731/job/17204715392?pr=861
@kenjiskenjis
removed
the 
help wanted
Extra attention is needed
label
Sep 28, 2023
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
b319800 to
a54e614CompareSeptember 28, 2023 05:06
@kenjis
kenjis
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
I created a new PR for GitHub Actions. #863
@kenjis
kenjis
marked this pull request as ready for review
September 28, 2023 05:07
@kenjiskenjis
mentioned this pull request
Sep 28, 2023
 Merged

1 task
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
a54e614 to
7a680c8CompareSeptember 28, 2023 06:24
datamweb
datamweb
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/Config/Auth.php
 * --------------------------------------------------------------------
 *
 * @var string[]
 * Do not use string rules like `required|valid_email`.
@datamwebdatamwebSep 29, 2023

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,

shouldn't the changes be applied to the documentation?
// 'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]','rules' => 'required|max_byte[72]',
// and ...
@kenjiskenjisSep 30, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@kenjis
kenjisforce-pushed
the
refactor-validation-rules
branch
from
7a680c8 to
8badb41CompareSeptember 30, 2023 07:01
datamweb
datamweb
approved these changes
Sep 30, 2023
View reviewed changes
@datamwebdatamweb
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀.
@kenjis
kenjis
merged commit 1d9a659
into
codeigniter4:developSep 30, 2023
@kenjis
kenjis
deleted the

refactor-validation-rules

branch
September 30, 2023 07:28
@sammyskillssammyskills
mentioned this pull request
Sep 30, 2023
 Merged

2 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@datamweb