Skip to content

Update devkit - #348

Merged
kenjis merged 9 commits into
codeigniter4projects:developfrom
kenjis:update-devkit
Dec 25, 2022
Merged

Update devkit#348
kenjis merged 9 commits into
codeigniter4projects:developfrom
kenjis:update-devkit

Conversation

@kenjis

@kenjiskenjis commented Dec 23, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#333

@kenjis
chore: composer update
63ed9ad
@kenjis
style: run php-cs-fixer
bedf121
@kenjis
chore: update php-cs-fixer commands in composer.json
776d567
@kenjis
chore: update .php-cs-fixer.dist.php
120584f
@kenjis
chore: update rector.php
ad5bccb
@kenjis
test: refactor by rector
277316d
@kenjis
refactor: workaround for PHPStan errors
4164f4c
 ------ -------------------------------------------------------------------------------------
Line app/Libraries/Blog.php
------ -------------------------------------------------------------------------------------
253 Negated boolean expression is always true.
💡 Because the type is coming from a PHPDoc, you can turn off this check by setting
treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.
255 Negated boolean expression is always false.
262 Negated boolean expression is always true.
269 Unreachable statement - code above always terminates.
------ -------------------------------------------------------------------------------------
@coveralls

coveralls commented Dec 23, 2022•
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3762475011

  • 1 of 1(100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%
TotalsCoverage Status
Change from base Build 3762143062:0.0%
Covered Lines:243
Relevant Lines:329
💛 - Coveralls

@kenjiskenjis added the github_actions Pull requests that update Github_actions code label Dec 23, 2022
MGatner
MGatner approved these changes Dec 24, 2022
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis
kenjis merged commit cefcc6f into codeigniter4projects:developDec 25, 2022
@kenjis
kenjis deleted the update-devkit branch December 25, 2022 09:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes
@ArhellArhellArhell approved these changes

Assignees

No one assigned

Labels

github_actionsPull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Infection develop fails

4 participants

@kenjis@coveralls@MGatner@Arhell