chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 6 commits into from
Sep 29, 2023
Merged

chore: update github workflows #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5961d93
chore: update workflows
kenjis Sep 29, 2023
2d0fe06
chore: update rector.php
kenjis Sep 29, 2023
734d4d3
chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false
kenjis Sep 29, 2023
18ac989
refactor: by rector
kenjis Sep 29, 2023
dd736a1
chore: update phpunit.yml
kenjis Sep 29, 2023
c47b3fe
chore: fix infection.yml
kenjis Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 57 additions & 10 deletions .github/workflows/infection.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
- 'composer.*'
- 'phpunit*'
- '.github/workflows/infection.yml'
push:
branches:
- develop
paths:
- '**.php'
- 'composer.*'
- 'phpunit*'
- '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
infection:
uses: codeigniter4/.github/.github/workflows/infection.yml@main
main:
name: Mutation Testing
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[ci skip]')"

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'
tools: infection, phpunit
extensions: intl, json, mbstring, gd, xml, sqlite3
coverage: xdebug
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Set up problem matchers for PHPUnit
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

- name: Configure matchers
uses: mheap/phpunit-matcher-action@v1

- name: Get composer cache directory
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

- name: Cache composer dependencies
uses: actions/cache@v3
with:
path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Install dependencies
run: |
if [ -f composer.lock ]; then
composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
else
composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
fi

- name: Run Infection for added files only
run: |
git fetch --depth=1 origin $GITHUB_BASE_REF
infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
env:
GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
52 changes: 50 additions & 2 deletions .github/workflows/phpcsfixer.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
paths:
- '**.php'
- '.github/workflows/phpcsfixer.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
phpcsfixer:
uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
build:
name: PHP ${{ matrix.php-versions }} Coding Standards
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[ci skip]')"
strategy:
fail-fast: false
matrix:
php-versions: ['8.1']

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: json, tokenizer
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Get composer cache directory
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

- name: Cache composer dependencies
uses: actions/cache@v3
with:
path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Install dependencies
run: |
if [ -f composer.lock ]; then
composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
else
composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
fi

- name: Check code for standards compliance
run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff
63 changes: 61 additions & 2 deletions .github/workflows/phpstan.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
- 'composer.*'
- 'phpstan*'
- '.github/workflows/phpstan.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
phpstan:
uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
build:
name: PHP ${{ matrix.php-versions }} Static Analysis
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[ci skip]')"
strategy:
fail-fast: false
matrix:
php-versions: ['8.1']

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
tools: phpstan, phpunit
extensions: intl, json, mbstring, xml
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Get composer cache directory
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

- name: Cache composer dependencies
uses: actions/cache@v3
with:
path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Create PHPStan cache directory
run: mkdir -p build/phpstan

- name: Cache PHPStan results
uses: actions/cache@v3
with:
path: build/phpstan
key: ${{ runner.os }}-phpstan-${{ github.sha }}
restore-keys: ${{ runner.os }}-phpstan-

- name: Install dependencies
run: |
if [ -f composer.lock ]; then
composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
else
composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
fi

- name: Run static analysis
run: vendor/bin/phpstan analyze
6 changes: 3 additions & 3 deletions .github/workflows/phpunit.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
if: "!contains(github.event.head_commit.message, '[ci skip]')"
strategy:
matrix:
php-versions: ['7.4', '8.0', '8.1']
php-versions: ['8.1']

steps:
- name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
coverage: xdebug
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Get composer cache directory
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
TACHYCARDIA_MONITOR_GA: enabled
GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- if: matrix.php-versions == '8.0'
- if: matrix.php-versions == '8.1'
name: Run Coveralls
continue-on-error: true
run: |
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/rector.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
- 'composer.*'
- 'rector.php'
- '.github/workflows/rector.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
build:
Expand All@@ -26,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['7.4', '8.0', '8.1']
php-versions: ['8.1']

steps:
- name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
extensions: intl, json, mbstring, xml
coverage: none
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Get composer cache directory
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
fi

- name: Analyze for refactoring
run: |
composer global require --dev rector/rector:^0.15.1
rector process --dry-run --no-progress-bar
run: vendor/bin/rector process --dry-run --no-progress-bar
4 changes: 1 addition & 3 deletions app/Entities/GitHub/ReleasePromise.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

/**
* API call to fetch the additional data.
*
* @var Closure|null
*/
private $resolver;
private ?Closure $resolver = null;

/**
* Stores the resolver along with data.
Expand Down
2 changes: 1 addition & 1 deletion app/Libraries/Blog.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

foreach ($contents as $line) {
if (trim($line) === '---') {
$inFrontMatter = $inFrontMatter ? false : true;
$inFrontMatter = ! $inFrontMatter;

if (! $inFrontMatter) {
$inBody = true;
Expand Down
43 changes: 15 additions & 28 deletions rector.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->sets([
SetList::DEAD_CODE,
LevelSetList::UP_TO_PHP_74,
PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
PHPUnitSetList::PHPUNIT_CODE_QUALITY,
PHPUnitSetList::PHPUNIT_100,
]);

Expand DownExpand Up@@ -79,31 +78,14 @@

JsonThrowOnErrorRector::class,
StringifyStrNeedlesRector::class,
YieldDataProviderRector::class,

// Note: requires php 8
RemoveUnusedPromotedPropertyRector::class,
AnnotationWithValueToAttributeRector::class,

// Ignore tests that might make calls without a result
RemoveEmptyMethodCallRector::class => [
__DIR__ . '/tests',
],

// Ignore files that should not be namespaced to their folder
NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
__DIR__ . '/app/Helpers',
],

// May load view files directly when detecting classes
StringClassNameToClassConstantRector::class,

// May be uninitialized on purpose
AddDefaultValueForUndefinedVariableRector::class,

// PHPStan will report false positive errors
UnnecessaryTernaryExpressionRector::class => [
__DIR__ . '/app/Libraries/Blog.php',
],
]);

// auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
$rectorConfig->rule(SimplifyUselessVariableRector::class);
$rectorConfig->rule(RemoveAlwaysElseRector::class);
$rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
$rectorConfig->rule(ForToForeachRector::class);
$rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
$rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
$rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
$rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
$rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
$rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
$rectorConfig->rule(AddPregQuoteDelimiterRector::class);
$rectorConfig->rule(SimplifyRegexPatternRector::class);
$rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
$rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
$rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
$rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
$rectorConfig
->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
/**
* The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
* Set to true for projects that allow BC break
*/
TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
]);
$rectorConfig->rule(StringClassNameToClassConstantRector::class);
$rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
$rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: update github workflows#404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

kenjis
merged 6 commits into

from

Sep 29, 2023
 Merged


chore: update github workflows
#404
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
5961d93

chore: update workflows


kenjis Sep 29, 2023
2d0fe06

chore: update rector.php


kenjis Sep 29, 2023
734d4d3

chore: change TypedPropertyFromAssignsRector::INLINE_PUBLIC to false


kenjis Sep 29, 2023
18ac989

refactor: by rector


kenjis Sep 29, 2023
dd736a1

chore: update phpunit.yml


kenjis Sep 29, 2023
c47b3fe

chore: fix infection.yml


kenjis Sep 29, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


67 changes: 57 additions & 10 deletions
.github/workflows/infection.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,15 +9,62 @@ on:
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
push:
 branches:
 - develop
 paths:
 - '**.php'
 - 'composer.*'
 - 'phpunit*'
 - '.github/workflows/infection.yml'
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

permissions:
contents: read

jobs:
 infection:
 uses: codeigniter4/.github/.github/workflows/infection.yml@main
 main:
 name: Mutation Testing
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: '8.1'
 tools: infection, phpunit
 extensions: intl, json, mbstring, gd, xml, sqlite3
 coverage: xdebug
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Set up problem matchers for PHPUnit
 run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

 - name: Configure matchers
 uses: mheap/phpunit-matcher-action@v1

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run Infection for added files only
 run: |
 git fetch --depth=1 origin $GITHUB_BASE_REF
 infection --threads=max --git-diff-lines --git-diff-base=origin/$GITHUB_BASE_REF --ignore-msi-with-no-mutations --only-covered --logger-github
 env:
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

52 changes: 50 additions & 2 deletions
.github/workflows/phpcsfixer.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,55 @@ on:
 paths:
 - '**.php'
 - '.github/workflows/phpcsfixer.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpcsfixer:
 uses: codeigniter4/.github/.github/workflows/phpcsfixer.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Coding Standards
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Set up PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 extensions: json, tokenizer
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Check code for standards compliance
 run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --using-cache=no --diff

63 changes: 61 additions & 2 deletions
.github/workflows/phpstan.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,66 @@ on:
 - 'composer.*'
 - 'phpstan*'
 - '.github/workflows/phpstan.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 phpstan:
 uses: codeigniter4/.github/.github/workflows/phpstan.yml@main
 build:
 name: PHP ${{ matrix.php-versions }} Static Analysis
 runs-on: ubuntu-latest
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['8.1']

 steps:
 - name: Checkout
 uses: actions/checkout@v4

 - name: Setup PHP
 uses: shivammathur/setup-php@v2
 with:
 php-version: ${{ matrix.php-versions }}
 tools: phpstan, phpunit
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV

 - name: Cache composer dependencies
 uses: actions/cache@v3
 with:
 path: ${{ env.COMPOSER_CACHE_FILES_DIR }}
 key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}-${{ hashFiles('**/composer.lock') }}
 restore-keys: ${{ runner.os }}-composer-

 - name: Create PHPStan cache directory
 run: mkdir -p build/phpstan

 - name: Cache PHPStan results
 uses: actions/cache@v3
 with:
 path: build/phpstan
 key: ${{ runner.os }}-phpstan-${{ github.sha }}
 restore-keys: ${{ runner.os }}-phpstan-

 - name: Install dependencies
 run: |
 if [ -f composer.lock ]; then
 composer install --no-progress --no-interaction --prefer-dist --optimize-autoloader
 else
 composer update --no-progress --no-interaction --prefer-dist --optimize-autoloader
 fi

 - name: Run static analysis
 run: vendor/bin/phpstan analyze

6 changes: 3 additions & 3 deletions
.github/workflows/phpunit.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@ jobs:
 if: "!contains(github.event.head_commit.message, '[ci skip]')"
 strategy:
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -39,7 +39,7 @@ jobs:
 extensions: intl, json, mbstring, gd, xdebug, xml, sqlite3
 coverage: xdebug
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -66,7 +66,7 @@ jobs:
 TACHYCARDIA_MONITOR_GA: enabled
 GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - if: matrix.php-versions == '8.0'
 - if: matrix.php-versions == '8.1'
 name: Run Coveralls
 continue-on-error: true
 run: |
Expand Down

16 changes: 11 additions & 5 deletions
.github/workflows/rector.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,14 @@ on:
 - 'composer.*'
 - 'rector.php'
 - '.github/workflows/rector.yml'
 workflow_call:

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

permissions:
 contents: read

jobs:
 build:
Expand All@@ -26,7 +34,7 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
 php-versions: ['7.4', '8.0', '8.1']
 php-versions: ['8.1']

 steps:
 - name: Checkout
Expand All@@ -40,7 +48,7 @@ jobs:
 extensions: intl, json, mbstring, xml
 coverage: none
 env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

 - name: Get composer cache directory
 run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV
Expand All@@ -61,6 +69,4 @@ jobs:
 fi

 - name: Analyze for refactoring
 run: |
 composer global require --dev rector/rector:^0.15.1
 rector process --dry-run --no-progress-bar
 run: vendor/bin/rector process --dry-run --no-progress-bar

4 changes: 1 addition & 3 deletions
app/Entities/GitHub/ReleasePromise.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,10 +25,8 @@ class ReleasePromise extends Release

 /**
 * API call to fetch the additional data.
 *
 * @var Closure|null
 */
 private $resolver;
 private ?Closure $resolver = null;

 /**
 * Stores the resolver along with data.
Expand Down

2 changes: 1 addition & 1 deletion
app/Libraries/Blog.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -250,7 +250,7 @@ protected function readPost(string $folder, string $filename)

 foreach ($contents as $line) {
 if (trim($line) === '---') {
 $inFrontMatter = $inFrontMatter ? false : true;
 $inFrontMatter = ! $inFrontMatter;

 if (! $inFrontMatter) {
 $inBody = true;
Expand Down

43 changes: 15 additions & 28 deletions
rector.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
<?php

declare(strict_types=1);

use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
use Rector\CodeQuality\Rector\Expression\InlineIfToExplicitIfRector;
use Rector\CodeQuality\Rector\For_\ForToForeachRector;
use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
Expand All@@ -21,27 +21,26 @@
use Rector\Config\RectorConfig;
use Rector\Core\ValueObject\PhpVersion;
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
use Rector\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
use Rector\PHPUnit\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
use Rector\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return static function (RectorConfig $rectorConfig): void {
 $rectorConfig->sets([
 SetList::DEAD_CODE,
 LevelSetList::UP_TO_PHP_74,
 PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD,
 PHPUnitSetList::PHPUNIT_CODE_QUALITY,
 PHPUnitSetList::PHPUNIT_100,
 ]);

Expand DownExpand Up@@ -79,31 +78,14 @@

 JsonThrowOnErrorRector::class,
 StringifyStrNeedlesRector::class,
 YieldDataProviderRector::class,

 // Note: requires php 8
 RemoveUnusedPromotedPropertyRector::class,
 AnnotationWithValueToAttributeRector::class,

 // Ignore tests that might make calls without a result
 RemoveEmptyMethodCallRector::class => [
 __DIR__ . '/tests',
 ],

 // Ignore files that should not be namespaced to their folder
 NormalizeNamespaceByPSR4ComposerAutoloadRector::class => [
 __DIR__ . '/app/Helpers',
 ],

 // May load view files directly when detecting classes
 StringClassNameToClassConstantRector::class,

 // May be uninitialized on purpose
 AddDefaultValueForUndefinedVariableRector::class,

 // PHPStan will report false positive errors
 UnnecessaryTernaryExpressionRector::class => [
 __DIR__ . '/app/Libraries/Blog.php',
 ],
 ]);

 // auto import fully qualified class names
Expand All@@ -112,7 +94,6 @@
 $rectorConfig->rule(SimplifyUselessVariableRector::class);
 $rectorConfig->rule(RemoveAlwaysElseRector::class);
 $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
 $rectorConfig->rule(ForToForeachRector::class);
 $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
 $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
 $rectorConfig->rule(SimplifyStrposLowerRector::class);
Expand All@@ -125,12 +106,18 @@
 $rectorConfig->rule(UnusedForeachValueToArrayKeysRector::class);
 $rectorConfig->rule(ChangeArrayPushToArrayAssignRector::class);
 $rectorConfig->rule(UnnecessaryTernaryExpressionRector::class);
 $rectorConfig->rule(AddPregQuoteDelimiterRector::class);
 $rectorConfig->rule(SimplifyRegexPatternRector::class);
 $rectorConfig->rule(FuncGetArgsToVariadicParamRector::class);
 $rectorConfig->rule(MakeInheritedMethodVisibilitySameAsParentRector::class);
 $rectorConfig->rule(SimplifyEmptyArrayCheckRector::class);
 $rectorConfig->rule(NormalizeNamespaceByPSR4ComposerAutoloadRector::class);
 $rectorConfig
 ->ruleWithConfiguration(TypedPropertyFromAssignsRector::class, [
 /**
 * The INLINE_PUBLIC value is default to false to avoid BC break, if you use for libraries and want to preserve BC break, you don't need to configure it, as it included in LevelSetList::UP_TO_PHP_74
 * Set to true for projects that allow BC break
 */
 TypedPropertyFromAssignsRector::INLINE_PUBLIC => false,
 ]);
 $rectorConfig->rule(StringClassNameToClassConstantRector::class);
 $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
 $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
Expand Down