Skip to content

Issue #122: support perforce - first part - #123

Open
stardust85 wants to merge 15 commits into
codeinn:masterfrom
stardust85:p4
Open

Issue #122: support perforce - first part#123
stardust85 wants to merge 15 commits into
codeinn:masterfrom
stardust85:p4

Conversation

@stardust85

Copy link
Copy Markdown
Contributor

parsing of p4 command and get_changesets partially works. Tests work. I run them this way:

PYTHONPATH=. python vcs/tests/test_p4.py

@stardust85stardust85 changed the title P4Issue #123: support perforce - first partJan 7, 2016
@stardust85stardust85 changed the title Issue #123: support perforce - first partIssue #122: support perforce - first partJan 7, 2016
@stardust85

Copy link
Copy Markdown
ContributorAuthor

The travis error message is strange, it doesn't look like it is caused by my changes. It fails much earlier.

Comment threadvcs/backends/p4/changeset.py Outdated

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a standard field for this? This way it will not be possible to use my_changest.time regardless of my_changest's type (P4Changeset vs GitChangest vs HgChangeset)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We implemented date as a base for all 3 vcs-es.

@stardust85

Copy link
Copy Markdown
ContributorAuthor

Any update on this pull request? Is there anything I can help with?

I don't want to be out of sync with you guys for long time so our branches don't diverge too much.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stardust85@marcinkuzminski