fix(recall): exclude superseded lessons from lessons.jsonl retrieval

[diazMelgarejo]

Summary

recall.py's _load_structured() already dedupes lessons.jsonl by latest row per id — handling retraction correctly, since retract_lesson.py appends a same-id row rather than editing in place. It has no supersession awareness though: supersession creates a new id whose supersedes field points at the old one, and the old row's own status stays "accepted" forever (supersession never edits it). Proactive recall can return both the stale and the replacement guidance for the same topic.

render_lessons.py's _build_auto_section already computes exactly this — an old-id → new-id map, accepted-supersessions-only (a provisional --supersedes must not retire the old lesson before its replacement is itself accepted, or retrieval momentarily has no active guidance on that topic at all).

Change

Extracted that computation into a public superseded_by_map(lessons) function in render_lessons.py, and import it from recall.py rather than re-deriving the same rule a second time. Retrieval and rendering now share one source of truth for "which lessons are currently retired," instead of two copies that can drift apart — which is how this gap happened in the first place.

Minimal diff: 2 files, ~29 lines of actual code change (plus a new test file).

Tests

tests/test_recall_supersession.py (new):

• superseded lesson excluded from _load_structured()
• recall() ranks the replacement, not the superseded lesson (concrete trigger: querying "git branch -f cherry-pick rollback update-ref" previously ranked a superseded "silent no-op" lesson alongside its corrected "exit 128" replacement)
• provisional supersession does not retire the old lesson
• direct unit test on superseded_by_map itself, independent of the recall/render integration

python3 -m pytest tests/test_recall_supersession.py tests/test_retract_lesson.py -v
# 8 passed

Full suite: 179 passed, 1 pre-existing failure unrelated to this change (test_unknown_executable_is_a_structured_start_failure — a macOS PermissionError-vs-FileNotFoundError platform quirk; confirmed via git stash that it fails identically on a clean checkout of master).

Note

Exclude superseded lessons from _load_structured retrieval in recall

• Extracts a new superseded_by_map() function in render_lessons.py that maps retired lesson IDs to their accepted replacements; shared between rendering and retrieval.
• Updates recall.py to compute this map after loading lessons and skip any lesson whose ID appears as superseded by an accepted successor.
• Adds tests/test_recall_supersession.py covering exclusion of superseded lessons, ranking of replacements, and the edge case where a provisional (non-accepted) supersession does not retire the old lesson.
• Behavioral Change: _load_structured now returns only the replacement lesson when a supersession is accepted, not both the old and new lessons.

^{Macroscope summarized fb51f82.}

[diazMelgarejo]

Related, independent PRs from the same review pass — each stands on its own, no dependency between them:

• fix(io): force UTF-8 on stdout/stderr and candidate writes #61 — UTF-8 stdout/stderr + candidate writes in learn.py
• fix(io): use a context manager in _lesson_already_appended #62 — context manager in _lesson_already_appended (stacked on fix(io): force UTF-8 on stdout/stderr and candidate writes #61's branch on the fork side, but both PRs target master directly per GitHub's cross-repo base requirement)
• fix(upgrade): loop-* skill copy doubles the skills/ path segment #63 — unrelated bug found while reviewing this same area: harness_manager/upgrade.py's loop-skill installer doubles a path segment

cc @codejunkie99 — happy to answer questions on any of these, or squash/reorder however's easiest to review.