Skip to content

feat: Add rate limiting middleware - #140

Merged
codekeyz merged 9 commits into
codekeyz:mainfrom
heyOnuoha:feature/rate-limiting-middleware
Sep 11, 2025
Merged

feat: Add rate limiting middleware#140
codekeyz merged 9 commits into
codekeyz:mainfrom
heyOnuoha:feature/rate-limiting-middleware

Conversation

@heyOnuoha

@heyOnuohaheyOnuoha commented Sep 1, 2025•
edited by codekeyz
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds a Rate Limiting Middleware to pharaoh middlewares.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@heyOnuoha
feat: Add pharaoh_rate_limit middleware package
2437a1e
- Implement token bucket and sliding window rate limiting algorithms
- Add configurable middleware with Express.js-like API
- Include comprehensive test coverage (18 tests passing)
- Add examples and documentation
- Support custom key generation, skip functions, and headers
- Compatible with existing Pharaoh middleware system
@heyOnuoha
fix: Update pharaoh_examples rate limiting demo
19c6ac5
- Fix import path and API usage for rate limiting example
- Add proper dependency configuration in pubspec.yaml
- Create comprehensive test script demonstrating all features
- Verify rate limiting works with token bucket and sliding window
- Test custom key generation, skip functionality, and headers
@heyOnuoha
Refactor rate limiting code for style and clarity
1725029
This commit applies consistent formatting, improves code readability, and fixes minor whitespace issues across rate limiting middleware, algorithms, and example/test files. No functional changes were made; the update is purely stylistic to enhance maintainability.
@heyOnuoha
fix: Remove unused variable in rate limiting test script
de7720c
- Fix dart analyze warning for unused 'body' variable
- Consume response body without storing in unused variable
- All analysis checks now pass
@codekeyz

codekeyz commented Sep 2, 2025

Copy link
Copy Markdown
Owner

Looks good to me. @heyOnuoha

Worth adding actual http tests that verify the rate limiting in action.

@codekeyzcodekeyz added the enhancement New feature or request label Sep 2, 2025
@codekeyzcodekeyz changed the title add feature limiting middlewarefeat: Add rate limiting middlewareSep 2, 2025
@codekeyz
codekeyz self-requested a review September 2, 2025 00:30
@heyOnuoha

heyOnuoha commented Sep 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks good to me. @heyOnuoha

Worth adding actual http tests that verify the rate limiting in action.

Got it @codekeyz, Will add that in

@heyOnuoha
feat: Add HTTP integration tests for rate limiting middleware
8eeb308
- Create comprehensive HTTP tests that verify rate limiting in action
- Test 429 responses, rate limit headers, and middleware behavior
- Address maintainer feedback for actual HTTP verification
- Include tests for custom key generation and skip functionality
- All existing unit tests continue to pass (18 tests)
@heyOnuoha
feat: Add clean HTTP integration test using Spookie framework
39481fa
- Create focused HTTP test that verifies rate limiting in action
- Test 429 responses, rate limit headers, and middleware behavior
- Use Spookie framework following Pharaoh testing patterns
- Remove complex HTTP client test attempts
- All 22 tests now pass including HTTP integration tests
- Addresses maintainer feedback for actual HTTP verification
@heyOnuoha
Add coverage reports and remove example test
f964711
Added new code coverage JSON reports for multiple test files across pharaoh, pharaoh_basic_auth, pharaoh_jwt_auth, pharaoh_rate_limit, spanner, and spookie packages. Removed the unused test_rate_limiting.dart from pharaoh_examples and updated rate_limit_http_test.dart in pharaoh_rate_limit.
codekeyz
codekeyz requested changes Sep 2, 2025
View reviewed changes

@codekeyzcodekeyz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added some new files by mistake **.dart.vm.json

@heyOnuoha

heyOnuoha commented Sep 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I think you added some new files by mistake **.dart.vm.json

Yes, that file was generated by the coverate script melos exec -c 1 -- "dart test --coverage=coverage" --fail-fast

@codekeyz

codekeyz commented Sep 4, 2025

Copy link
Copy Markdown
Owner

I think you added some new files by mistake **.dart.vm.json

Yes, that file was generated by the coverate script melos exec -c 1 -- "dart test --coverage=coverage" --fail-fast

You'll need to remove them. We don't need them aded to the repo.

@heyOnuoha

heyOnuoha commented Sep 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I think you added some new files by mistake **.dart.vm.json

Yes, that file was generated by the coverate script melos exec -c 1 -- "dart test --coverage=coverage" --fail-fast

You'll need to remove them. We don't need them aded to the repo.

Alright got it, I'll take them out

@heyOnuoha
Delete api_service_test.dart.vm.json
a4aed48
@heyOnuoha
Remove generated test coverage JSON files
0b446d8
Deleted multiple .vm.json files containing test coverage data from various package directories. This cleanup likely prepares for regeneration of coverage reports or reduces repository size by removing generated artifacts.
@codekeyz

codekeyz commented Sep 11, 2025

Copy link
Copy Markdown
Owner

Looks good to me, I'll merge now ✅

@codekeyz
codekeyz merged commit 061ca82 into codekeyz:mainSep 11, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codekeyzcodekeyzcodekeyz approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heyOnuoha@codekeyz