Uh oh!
There was an error while loading. Please reload this page.
fix(ci): make the codeanalyzer-JAR release guard pipe-safe (#284) - #287
Merged
Conversation
The guard piped `tar tzf` (which decompresses the whole ~32MB sdist) straight into `grep -q`; grep closes the pipe on first match, SIGPIPE-killing tar, and under `set -o pipefail` that surfaced as a false "missing JAR" — failing the v1.4.4 release even though the JAR was present in both wheel and sdist. Capture each listing with command substitution and grep a here-string instead, so no producer is still writing when grep short-circuits. (#284)
This was referenced Jul 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #285. The v1.4.4 release (run 29934029805) failed at the new JAR guard with a false
dist/cldk-1.4.4.tar.gz is missing the codeanalyzer JAR— thetar: stdout: write errorin the log is the tell.Cause
tar tzf "$f" | grep -qE …underset -o pipefail:grep -qexits on first match and closes the pipe, SIGPIPE-killingtar(still decompressing the 32MB sdist).pipefailthen reports the pipeline as failed even though the JAR was found. The wheel check passed becauseunzip -lreads the zip central directory (small/fast) and finishes before grep closes.The
artifactsfix from #285 works — the JAR is in both the wheel and the sdist. Only the guard was buggy.Fix
Capture each listing via command substitution, then grep a here-string — no live pipeline, so nothing to SIGPIPE. Verified locally: passes on jar-bundled wheel+sdist, still fails (with a diagnostic dump) on a jarless wheel.