Uh oh!
There was an error while loading. Please reload this page.
ci: fix empty release notes (#289) + remove obsolete native-binary test (#290) - #291
Merged
Conversation
test_get_codeanalyzer_exec asserted the old native invocation [sys.executable, -m, codeanalyzer_java], but there is no codeanalyzer-native build anymore — _get_codeanalyzer_exec() resolves a cached JDK and runs the bundled jar ([java, -jar, <jar>]). The test failed in CI (masked by continue-on-error). Drop it and its now-unused `sys` import.
The label-based mikepenz changelog scraper emitted nothing for unlabeled release
PRs ("Wrote 0 categorized pull requests"), blanking the GitHub release body and
crashing the org-announcement step with 'Body can't be blank'. Extract the release
body from the hand-written CHANGELOG.md section for the tag instead, and hard-fail
the release if that section is empty. Drop the label-dependent scraper, the
mis-wired changelog-reader step, and the orphaned release_config.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#289. Fixes#290.
Two release-workflow follow-ups found while shipping v1.4.4, in one branch as requested.
#289 — release notes came out empty (and crashed the org announcement)
release.ymlbuilt the release body frommikepenz/release-changelog-builder-action, whoserelease_config.jsoncategorizes PRs strictly by label. v1.4.4's PRs were unlabeled, so the action loggedWrote 0 categorized pull requests→ emptychangelog→ blank GitHub release body → blankBODYfor the orgcreateDiscussion→gh: Body can't be blank(masked bycontinue-on-error).Fix: extract the release body from the hand-written
CHANGELOG.mdsection for the tag (deterministic, label-independent — and aligned with the "grounded in CHANGELOG.md" announcement policy), and hard-fail the release if that section is empty so a blank body can never publish again. Removes the label-based scraper, the mis-wiredchangelog-readerstep (it read a non-existentsteps.tag_nameoutput), and the now-orphanedrelease_config.json.Verified locally: the
awkextractor pulls the correct section forv1.4.4/v1.4.3, writes a multilinenotesoutput, and the guard trips on a missing/empty entry.#290 — obsolete native-binary test
test_get_codeanalyzer_execasserted_get_codeanalyzer_exec() == [sys.executable, "-m", "codeanalyzer_java"], but there's no codeanalyzer-native build anymore — the backend resolves a cached JDK and runs the bundled jar ([java, -jar, <jar>]). The test failed in CI (masked bycontinue-on-error). Removed it and its now-unusedimport sys.Verified:
tests/analysis/java/test_jcodeanalyzer.py→ 42 passed.