Skip to content

Fix dead release test gate: use outcome, not conclusion#306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahlk merged 1 commit into from
Aug 3, 2026
Merged

Fix dead release test gate: use outcome, not conclusion #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,11 +41,17 @@ jobs:

- name: Run Tests
id: test
# continue-on-error is deliberate: without it a red suite fails the job
# immediately and the tag-deletion step below never runs. It must be paired
# with `outcome` (not `conclusion`) in that step — see the comment there.
continue-on-error: true
run: uv run make test

- name: Delete tag on failure
if: steps.test.conclusion == 'failure'
# MUST be `outcome`, not `conclusion`: continue-on-error rewrites `conclusion`
# to `success`, so `steps.test.conclusion == 'failure'` is never true and this
# step never fires. `outcome` preserves the step's real result.
if: steps.test.outcome == 'failure'
run: |
echo "Tests failed. Deleting tag ${GITHUB_REF#refs/tags/}..."
git push --delete origin ${GITHUB_REF#refs/tags/}
Expand Down